Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GH workflow to validate PR titles follow Conventional Commits (fixes #43). #48

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

LinZhihao-723
Copy link
Member

@LinZhihao-723 LinZhihao-723 commented Dec 1, 2024

References

Description

This PR implements #43

Convention Commits is a specification for writing commit messages (or in our case, PR titles) that makes it easy to see at a glance what change the commit makes which in turn makes it easier to generate release notes.

This PR adds a workflow to check PR titles match the spec.

Validation performed

  • Already validated this workflow in other repos, including CLP core, log surgeon, and clp-ffi-py.

Summary by CodeRabbit

  • New Features

    • Introduced a new GitHub Actions workflow to validate pull request titles based on the Conventional Commits specification.
    • Updated the pull request template to provide guidance on writing effective titles.
  • Documentation

    • Removed the "References" section from the pull request template and added comments to improve clarity on title formatting.

Copy link

coderabbitai bot commented Dec 1, 2024

Walkthrough

The changes in this pull request involve modifications to the pull request template and the introduction of a new GitHub Actions workflow. The .github/PULL_REQUEST_TEMPLATE.md file has been updated to remove the "References" section and includes new guidance for writing pull request titles according to the Conventional Commits specification. Additionally, a new workflow file named pr-title-checks.yaml has been added, which triggers on specific pull request events and runs a job to enforce semantic pull request title standards.

Changes

File Path Change Summary
.github/PULL_REQUEST_TEMPLATE.md Removed "References" section; added guidance for writing the pull request title in imperative form.
.github/workflows/pr-title-checks.yaml Introduced a new workflow that triggers on pull request events to check for conventional commit title standards.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHub
    participant Action

    User->>GitHub: Open/Edit/Reopen Pull Request
    GitHub->>Action: Trigger pr-title-checks workflow
    Action->>GitHub: Check Pull Request Title
    GitHub->>User: Provide Feedback on Title
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6422802 and 39d9236.

📒 Files selected for processing (2)
  • .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
  • .github/workflows/pr-title-checks.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/PULL_REQUEST_TEMPLATE.md
  • .github/workflows/pr-title-checks.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
.github/workflows/pr-title-checks.yaml (1)

15-23: Consider customizing the semantic validation rules

While the basic configuration is secure and functional, consider adding custom validation rules to better match your project's needs. The action supports additional configuration options such as:

  • Custom commit types
  • Scope validation
  • Custom error messages

Example configuration:

       - uses: "amannn/action-semantic-pull-request@v5"
         env:
           GITHUB_TOKEN: "${{secrets.GITHUB_TOKEN}}"
+        with:
+          types: |
+            feat
+            fix
+            docs
+            style
+            refactor
+            perf
+            test
+            build
+            ci
+            chore
+          requireScope: false
+          wip: true
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 43d1eaa and 0827815.

📒 Files selected for processing (2)
  • .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
  • .github/workflows/pr-title-checks.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/PULL_REQUEST_TEMPLATE.md
🔇 Additional comments (1)
.github/workflows/pr-title-checks.yaml (1)

8-12: Well-implemented concurrency settings!

The concurrency configuration effectively prevents redundant checks and improves workflow efficiency by cancelling outdated runs. The commenting is clear and helpful.

.github/workflows/pr-title-checks.yaml Outdated Show resolved Hide resolved
.github/workflows/pr-title-checks.yaml Show resolved Hide resolved
.github/workflows/pr-title-checks.yaml Outdated Show resolved Hide resolved
@LinZhihao-723 LinZhihao-723 merged commit e2930e4 into y-scope:main Dec 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants