Update clp-ffi-py dependency; Drop support for Python3.6. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlion
requested changes
Apr 21, 2024
README.md
Outdated
Comment on lines
212
to
214
| ## Compatibility | ||
|
|
||
| Tested on Python 3.6, 3.8, and 3.11 (should also work on newer versions). | ||
| Tested on Python 3.8 and 3.11 (should also work on newer versions). |
There was a problem hiding this comment.
I think we can edit/reword this section to explicitly say our minimum supported version is 3.7. We should probably test on 3.7 considering that is the minimum required version in pyproject.toml.
There was a problem hiding this comment.
We don't need to explicitly state the minimum supported version. It will be shown in the PyPI project home page :D
davidlion
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
clp-ffi-py0.0.11 release adds support for Windows build. This PR updatesclp-ffi-pydependency for future Windows support. Since the latestclp-ffi-pyhas dropped support for Python3.6, this PR should no longer support Python3.6 either.To fully support Windows build, we will still need a few changes to fix platform-dependent APIs in the coming PRs. Thus, we will not automate Windows build/test in our GitHub workflow until we have all the things fixed.
Validation performed
Passed existing GitHub workflows.