Skip to content

Commit 1757e5b

Browse files
committed
Pass emsdk path from Taskfile to CMake build; Fix emsdk task name in README.
1 parent 475dd1f commit 1757e5b

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Follow the steps below to develop and contribute to the project.
3434
## Set up
3535
Before opening the project in an IDE, you'll first need to download and install [emscripten]:
3636
```shell
37-
task emscripten
37+
task emsdk
3838
```
3939

4040
## Linting

Taskfile.yml

+7-2
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,13 @@ tasks:
5050
cmds:
5151
- "mkdir -p '{{.OUTPUT_DIR}}'"
5252
- |-
53-
cmake -S "{{.ROOT_DIR}}" -B "{{.OUTPUT_DIR}}" -G "Unix Makefiles"
54-
cmake --build "{{.OUTPUT_DIR}}" --parallel --target "{{.G_CLP_FFI_JS_TARGET_NAME}}"
53+
cmake \
54+
-G "Unix Makefiles" \
55+
-DCMAKE_TOOLCHAIN_FILE="{{.G_EMSDK_DIR}}/upstream/emscripten/cmake/Modules/Platform/\
56+
Emscripten.cmake" \
57+
-S "{{.ROOT_DIR}}" \
58+
-B "{{.OUTPUT_DIR}}"
59+
- "cmake --build '{{.OUTPUT_DIR}}' --parallel --target '{{.G_CLP_FFI_JS_TARGET_NAME}}'"
5560
# This command must be last
5661
- task: "utils:compute-checksum"
5762
vars:

0 commit comments

Comments
 (0)