Skip to content

Commit

Permalink
Pre-empt support for Node 10
Browse files Browse the repository at this point in the history
Lets try to avoid the rush of issues when Node 10 is released next
month.

Node 10 is currently version [`62`][1] but is expected to be
[`63`][2] before going stable. We need to pick one because of the
ABI breakage betweem 62 and 63.

If this bet pays off we save ourselves a bunch of time dealing with
installation issues, and avoiding a new release. If we're wrong it's
no different to any other major Node release.

[1]: https://github.com/nodejs/node/blob/97595739/src/node_version.h#L112
[2]: nodejs/node#19201
  • Loading branch information
xzyfer committed Mar 10, 2018
1 parent 863f29f commit 66a31af
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/extensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ function getHumanNodeVersion(abi) {
case 53: return 'Electron 1.6.x';
case 57: return 'Node.js 8.x';
case 59: return 'Node.js 9.x';
case 63: return 'Node.js 10.x';
default: return false;
}
}
Expand Down

0 comments on commit 66a31af

Please sign in to comment.