Skip to content
This repository has been archived by the owner on Oct 10, 2018. It is now read-only.

Remove AMP-illegal overflow values (auto, scroll) #82

Closed
wants to merge 1 commit into from

Conversation

westonruter
Copy link
Contributor

The new validity reporting in ampproject/amp-wp#971 brought to light that the overflow property in this theme had illegal values according to the spec:

overflow (and overflow-y, overflow-x) may not be styled as “auto” or “scroll”. No user defined element in an AMP document may have a scrollbar.

Since they are getting stripped by the sanitizer anyway, it seems they should be removed from the CSS. Alternatives should be explored if needed.

@westonruter
Copy link
Contributor Author

Without this change, the AMP validation utils will continue to complain with:

image

@westonruter
Copy link
Contributor Author

This will no longer be required as of ampproject/amp-wp#1048

@westonruter westonruter mentioned this pull request May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant