Skip to content
This repository has been archived by the owner on Oct 10, 2018. It is now read-only.

Create static comments section of single post. #24

Closed
kopepasah opened this issue Jan 12, 2018 · 6 comments
Closed

Create static comments section of single post. #24

kopepasah opened this issue Jan 12, 2018 · 6 comments

Comments

@kopepasah
Copy link
Contributor

kopepasah commented Jan 12, 2018

Going off the designs, create the static comment section of the single post. Please also refer to the comments.php block of the design.

@delawski delawski self-assigned this Jan 25, 2018
@delawski delawski added this to the v0.1 milestone Jan 26, 2018
@delawski
Copy link
Contributor

@kopepasah This is ready for CR: #47

@delawski delawski assigned kopepasah and unassigned delawski Jan 26, 2018
@delawski
Copy link
Contributor

Here's the screenshot of the comments area and forms when logged in and when not:

amp-comments

@westonruter
Copy link
Contributor

@kopepasah @delawski N.B. 👉 Comments are going to be implemented using amp-live-list, which will have some markup constraints: ampproject/amp-wp#909

@delawski
Copy link
Contributor

@westonruter I’ve touched base with @DavidCramer before starting development and he suggested using a default WordPress markup for comments. If it needs to be adjusted, I’m happy to support.

@kopepasah kopepasah removed their assignment Jan 31, 2018
@kienstra
Copy link
Contributor

Steps To Test

  1. Navigate to a single post on the test site
  2. Verify that comments appear
  3. Verify that you can make a comment as a logged-in and non-logged-in user
  4. There are known issues in this plugin commenting issue

@csossi
Copy link

csossi commented Feb 21, 2018

verified in QA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants