-
Notifications
You must be signed in to change notification settings - Fork 13
Issues 20 & 21: Add secondary featured posts, blog and sidebar along with widgets. #32
Conversation
* add/static-html-setup: 18 Add toggle state for mobile menu. 18 Use BEM on site header. Fix form AMP validation. # Conflicts: # assets/src/css/components/_wrap.scss
* add/static-html-setup: Build Assets. Remove unused class. 18 Use BEM on footer. 19 Fix toggle button styles. # Conflicts: # assets/dist/css/main.css
* develop:
default
and slim
entry cards.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delawski fantastic work on this! LGTM
@kopepasah I believe this can move onto BE implementation once your CR is done. Since it is late for @delawski, I would suggest to apply to final touch to make sure it validates and merge this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delawski this looks good to me and thanks for leaving the dev notes regarding the redirects for the widgets.
@ThierryA good to merge into develop. |
Notice Of Other PR Hi @kopepasah, |
@kienstra this PR just covers the frontend markup for the widgets. Nothing is in the dynamic templates as of yet. |
@kopepasah @ThierryA Please review this set of changes.
This PR adds styling and/or markup of the following elements:
select
boxchange
eventI've left dev notes in the templates needing BE support.