Skip to content
This repository has been archived by the owner on Oct 10, 2018. It is now read-only.

Issues 20 & 21: Add secondary featured posts, blog and sidebar along with widgets. #32

Merged
merged 24 commits into from
Jan 22, 2018

Conversation

delawski
Copy link
Contributor

@delawski delawski commented Jan 17, 2018

@kopepasah @ThierryA Please review this set of changes.

This PR adds styling and/or markup of the following elements:

  • the secondary featured posts (right after featured post on the homepage)
  • the article stream (used on homepage, archive, category etc.)
  • the sidebar (used on homepage, archive, category etc.)
  • the set of default WordPress widgets, i.e.:
    • meta,
    • recent comments,
    • recent entries,
    • RSS,
    • audio (needs markup adjustments in the BE to pass AMP validation),
    • video (needs markup adjustments in the BE to pass AMP validation),
    • search (needs markup adjustments in the BE to pass AMP validation),
    • the 'categories' widget is implemented partially, since it's not possible to implement redirect on select box change event
    • for the same reason as above, the 'archive' widget could not be implemented at all,
    • the 'tag cloud' widget needs a complete BE solution.
      I've left dev notes in the templates needing BE support.

issue-20-21

@delawski delawski changed the base branch from add/static-html-setup to develop January 19, 2018 14:12
@delawski delawski changed the title Issues 20 & 21: Add default and slim entry cards. Issues 20 & 21: Add secondary featured posts, blog and sidebar along with widgets. Jan 19, 2018
Copy link
Contributor

@ThierryA ThierryA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delawski fantastic work on this! LGTM

@ThierryA
Copy link
Contributor

ThierryA commented Jan 19, 2018

@kopepasah I believe this can move onto BE implementation once your CR is done. Since it is late for @delawski, I would suggest to apply to final touch to make sure it validates and merge this 👍

Copy link
Contributor

@kopepasah kopepasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delawski this looks good to me and thanks for leaving the dev notes regarding the redirects for the widgets.

@kopepasah
Copy link
Contributor

@ThierryA good to merge into develop.

@kienstra
Copy link
Contributor

kienstra commented Jan 20, 2018

Notice Of Other PR

Hi @kopepasah,
Plugin PR #870 involves adding support to native WordPress widgets. Have you begun implementing the widget templates here?

@kopepasah
Copy link
Contributor

@kienstra this PR just covers the frontend markup for the widgets. Nothing is in the dynamic templates as of yet.

@delawski delawski merged commit b3ee340 into develop Jan 22, 2018
@delawski delawski deleted the add/20 branch January 22, 2018 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants