-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetComments failed in some file #825
Comments
Thanks for your feedback, could you provide more details or a spreadsheet xlsx attachment without confidential info? |
comment.zip |
I have fixed it, please try to use the master branch code, and this patch will be released in the next version. |
Fixed qax-os#825, improves compatibility for comments with absolute XML path
this problem is not fix in windows. filepath.IsAbs("/xl/worksheets/sheet1.xml") return false in windows. |
I have fixed it, please try to use the master branch code. |
…ue when get and add comments on multi authors
The function "(f *File) GetComments() "may renturn empty in some file.
I find my excel file (xl\worksheets_rels\sheet1.xml.rels) is like this. The Target of comments is a abslute path, not a relatively path.
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="comments" Target="/xl/comments/comment2.xml" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/comments"/><Relationship Id="anysvml" Target="/xl/drawings/commentsDrawing2.vml" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/vmlDrawing"/></Relationships>
the implement of GetComments is like this:
f.commentsReader("xl" + strings.TrimPrefix(f.getSheetComments(filepath.Base(path)), ".."))
(see github.com/360EntSecGroup-Skylar/excelize/comment.go:42)
The text was updated successfully, but these errors were encountered: