Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: scientific notation zerofill issues #1710

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

phperic
Copy link
Contributor

@phperic phperic commented Nov 2, 2023

PR Details

I found a issue about cell value

Description

I found an issue with getting values from cells with scientific notation as their format.

Related Issue

#1709

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2023
@xuri xuri linked an issue Nov 2, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #1710 (1a0e0dc) into master (7291e78) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
- Coverage   99.03%   99.03%   -0.01%     
==========================================
  Files          32       32              
  Lines       28000    27999       -1     
==========================================
- Hits        27730    27729       -1     
  Misses        179      179              
  Partials       91       91              
Flag Coverage Δ
unittests 99.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
numfmt.go 100.00% <100.00%> (ø)

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit f753e56 into qax-os:master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Getting Values in Scientific Notation
3 participants