[NIXL] Refactor prefill-only ReqMeta into RemoteMeta#15
Merged
xuechendi merged 1 commit intoxuechendi:dev/fix_pd_host_bufferfrom Dec 12, 2025
Merged
Conversation
On the decode side, in reqs_to_save, we do not expect or need any of these remote_ fields - they are for the prefill side only. Make this more clear by putting these fields in their own dataclass which is only present on requests in reqs_to_recv. Signed-off-by: Mark McLoughlin <markmc@redhat.com>
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See vllm-project#30420
On the decode side, in
reqs_to_save, we do not expect or need any of theseremote_fields - they are for the prefill side only. Make this more clear by putting these fields in their owndataclasswhich is only present on requests inreqs_to_recv.