Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reward shaping not removed in test.py #2

Open
lerrytang opened this issue Mar 17, 2020 · 1 comment
Open

Reward shaping not removed in test.py #2

lerrytang opened this issue Mar 17, 2020 · 1 comment

Comments

@lerrytang
Copy link

Hi,

I notice that you've used some reward shaping during training, but forgot to remove it in in calculating the running average and in test.py, and that leads to incorrect results.
Commenting out relevant lines, I got an average score of around 860 over 100 episodes for the model in the repo.

@daggn3
Copy link

daggn3 commented Mar 16, 2022

what lines did comment out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants