Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the fit addon utilize the charMeasure object? #696

Closed
Tyriar opened this issue Jun 11, 2017 · 2 comments
Closed

Should the fit addon utilize the charMeasure object? #696

Tyriar opened this issue Jun 11, 2017 · 2 comments
Labels
type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 11, 2017

It's doing some hacky stuff to re-evaluate the size when I think it could just call term.charMeasure.measure and use that to determine the width/height.

https://github.com/sourcelair/xterm.js/blob/c33814a7a665ccdd39e8d72fedeac9b322327786/src/addons/fit/fit.js#L55
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Jun 11, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Jun 11, 2017

Alternatively just merging fit into the public API might be better, it would probably turn into a pretty small function when leaning on charMeasure. /cc @parisk

@Tyriar Tyriar mentioned this issue Jun 13, 2017
Open
@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2018

fit uses dimensions now which is derived from charmeasure 👍

@Tyriar Tyriar closed this as completed Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar