Skip to content

Commit 76ea6e2

Browse files
kobymeirxsoar-bot
authored andcommitted
sdk logging file size & rotation (demisto#29144)
* sdk logging file size & rotation
1 parent 2e9c921 commit 76ea6e2

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

Diff for: .circleci/config.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,9 @@ parameters:
5757
references:
5858
environment: &environment
5959
environment:
60-
# A flag for the demisto_client to not cache it's last response in order to avoid memory leaks
60+
# A flag for the demisto_client to not cache its last response in order to avoid memory leaks.
6161
DONT_CACHE_LAST_RESPONSE: "true"
62+
DEMISTO_SDK_LOG_FILE_SIZE: 1073741824 # 1GB
6263
ARTIFACT_BUILD_NUM: << pipeline.parameters.artifact_build_num >>
6364
CONTRIB_BRANCH: << pipeline.parameters.contrib_branch >>
6465
CONTRIB_PACK_NAME: << pipeline.parameters.contrib_pack_name >>

Diff for: .gitlab/ci/.gitlab-ci.global.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@
178178
- *get_last_upload_commit
179179
- *install_ssh_keys
180180
- section_start "Build Parameters"
181-
- set | grep -E "^NIGHTLY=|^INSTANCE_TESTS=|^SERVER_BRANCH_NAME=|^ARTIFACT_BUILD_NUM=|^DEMISTO_SDK_NIGHTLY=|^TIME_TO_LIVE=|^CONTRIB_BRANCH=|^FORCE_PACK_UPLOAD=|^PACKS_TO_UPLOAD=|^BUCKET_UPLOAD=|^STORAGE_BASE_PATH=|^OVERRIDE_ALL_PACKS=|^GCS_MARKET_BUCKET=|^GCS_MARKET_V2_BUCKET=|^GCS_MARKET_XPANSE_BUCKET=|^SLACK_CHANNEL=|^NVM_DIR=|^NODE_VERSION=|^PATH=|^ARTIFACTS_FOLDER=|^ENV_RESULTS_PATH=|^LAST_UPLOAD_COMMIT="
181+
- set | grep -E "^NIGHTLY=|^INSTANCE_TESTS=|^SERVER_BRANCH_NAME=|^ARTIFACT_BUILD_NUM=|^DEMISTO_SDK_NIGHTLY=|^TIME_TO_LIVE=|^CONTRIB_BRANCH=|^FORCE_PACK_UPLOAD=|^PACKS_TO_UPLOAD=|^BUCKET_UPLOAD=|^STORAGE_BASE_PATH=|^OVERRIDE_ALL_PACKS=|^GCS_MARKET_BUCKET=|^GCS_MARKET_V2_BUCKET=|^GCS_MARKET_XPANSE_BUCKET=|^SLACK_CHANNEL=|^NVM_DIR=|^NODE_VERSION=|^PATH=|^ARTIFACTS_FOLDER=|^ENV_RESULTS_PATH=|^LAST_UPLOAD_COMMIT=|^DEMISTO_SDK_LOG_FILE_SIZE=|^DEMISTO_SDK_LOG_FILE_COUNT=|^DEMISTO_SDK_LOG_FILE_PATH=|^DEMISTO_SDK_LOG_NO_COLORS=|^DEMISTO_SDK_LOG_NOTIFY_PATH="
182182
- neo4j-admin dbms set-initial-password contentgraph
183183
- neo4j start
184184
- python --version
@@ -273,14 +273,14 @@
273273
fi
274274
if [ -n "$SHOULD_LINT_ALL" ]; then
275275
echo -e "----------\nLinting all because:\n${SHOULD_LINT_ALL}\n----------"
276-
demisto-sdk lint -vvv -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image ${DOCKER}
276+
demisto-sdk lint -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image ${DOCKER}
277277
fi
278278
if [[ -n $BUCKET_UPLOAD ]]; then
279-
demisto-sdk lint -vvv -p 8 -g --no-mypy --prev-ver $LAST_UPLOAD_COMMIT -v --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
279+
demisto-sdk lint --console_log_threshold DEBUG -p 8 -g --no-mypy --prev-ver $LAST_UPLOAD_COMMIT -v --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
280280
else
281281
if [[ "$CI_COMMIT_BRANCH" != "master" ]]; then
282282
# skip running `lint -g` on master
283-
demisto-sdk lint -p 8 -g -vvv --test-xml ./unit-tests --log-path ./artifacts --failure-report ./artifacts --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
283+
demisto-sdk lint --console_log_threshold DEBUG -p 8 -g --test-xml ./unit-tests --log-path ./artifacts --failure-report ./artifacts --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
284284
fi
285285
fi
286286

Diff for: .gitlab/ci/.gitlab-ci.sdk-nightly.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ demisto-sdk-nightly:run-commands-against-instance:
206206
- demisto-sdk validate -i Packs/HelloWorld/
207207
- section_end "Run Validate"
208208
- section_start "Run Lint" --collapsed
209-
- demisto-sdk lint -i Packs/HelloWorld/ -vvv
209+
- demisto-sdk lint --console_log_threshold DEBUG -i Packs/HelloWorld/
210210
- section_end "Run Lint"
211211
- *change-file-ids
212212
- *upload-entities-to-cortex-xsoar

Diff for: .gitlab/ci/.gitlab-ci.test-native-candidate.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ test-native-candidate:run-lint-with-native-candidate:
3636
touch $ARTIFACTS_FOLDER/native_candidate_image.txt
3737
echo "$NATIVE_CANDIDATE_IMAGE" >> $ARTIFACTS_FOLDER/native_candidate_image.txt
3838
39-
demisto-sdk lint -vvv -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image native:target --docker-image-target "$NATIVE_CANDIDATE_IMAGE"
39+
demisto-sdk lint --console_log_threshold DEBUG -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image native:target --docker-image-target "$NATIVE_CANDIDATE_IMAGE"
4040
if [[ -f $ARTIFACTS_FOLDER/coverage_report/.coverage ]]; then
4141
demisto-sdk coverage-analyze -i $ARTIFACTS_FOLDER/coverage_report/.coverage --report-dir $ARTIFACTS_FOLDER/coverage_report --report-type all --allowed-coverage-degradation-percentage 100
4242
fi

0 commit comments

Comments
 (0)