Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add filters #22

Open
CJ-Wright opened this issue Jul 6, 2017 · 2 comments
Open

ENH: add filters #22

CJ-Wright opened this issue Jul 6, 2017 · 2 comments

Comments

@CJ-Wright
Copy link
Member

XPD has a set of four filters for attenuating the beam intensity. It would be nice to simulate this so we could create automated exposure algorithms.

Potential design:

  1. Similar to the shutter, have the detector take in a filter object which will manage the filters
  2. If there is a filter object then get the attenuation factor from the filters (which will depend on the filter positions).
  3. Multiply the image by the attenuation factor

Expected work:

  1. Build a filter object with a similar API to the filters here. This will require making 5 objects (4 filters, which have all the methods specified here except for maybe stop, and a 5th object combining them all). The filters will need to take in an argument which specifies how much it attenuates the beam. The composite will need to take these and multiply them together to create the effective attenuation.
  2. Add a kwarg (key word argument see Scopatz and Huff p. 99) for the composite filter. Default it to None.
  3. Change how the trigger works, if the kwarg is None do not get the attenuation factor when triggering the detector, otherwise use the get_attenuation method on the filters to attenuate the image data. This may require a design refactor where these steps are done sequentially. eg
    1. Get the image from disk (this one is already done)
    2. If the shutter is down zero the image (or maybe check it first and then load the image?)
    3. Use the filters to attenuate the image

Additional information needed:

  1. Need to take a good guess or ask the beamline scientists how much each of the filters attenuate the beam.
@CJ-Wright
Copy link
Member Author

@brookeferber

@CJ-Wright
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant