Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong-named assembly #63

Open
lahma opened this issue Dec 21, 2021 · 4 comments
Open

Strong-named assembly #63

lahma opened this issue Dec 21, 2021 · 4 comments

Comments

@lahma
Copy link

lahma commented Dec 21, 2021

Currently this library cannot be consumed from strong-named assembly. Would you accept a PR to add new generated snk file and directives to sign the assembly?

@xoofx
Copy link
Owner

xoofx commented Dec 22, 2021

Yes, as much as I hate SN 😅, it will require a separate NuGet (Zio.Signed). I'm usually handling it with a separate project only used in the CI (and not referenced by the sln). See Scriban.Signed for inspirations (it requires to extract props from the Zio project to import then in Zio.Signed)

@lahma
Copy link
Author

lahma commented Dec 22, 2021

I think the general advice from MS is just sign and give the key to public, is there a particular reason you don't want assembly be signed by default?

@xoofx
Copy link
Owner

xoofx commented Dec 22, 2021

I think the general advice from MS is just sign and give the key to public, is there a particular reason you don't want assembly be signed by default?

I have never had a need for them and they always caused more trouble to handle simple things (e.g drop a new version of the DLL in a folder can't be done without writing binding redirects)

@lahma
Copy link
Author

lahma commented Dec 22, 2021

OK, fair enough, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants