Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Failed to load plugin '*' declared in 'BaseConfig... #546

Closed
AndrewMSHowe opened this issue May 11, 2021 · 23 comments
Closed

Error: Failed to load plugin '*' declared in 'BaseConfig... #546

AndrewMSHowe opened this issue May 11, 2021 · 23 comments
Labels
bug help wanted

Comments

@AndrewMSHowe
Copy link

AndrewMSHowe commented May 11, 2021 •
edited
Loading

With 0.40.1, xo --help works. But in my project folder, xo gives:
Error: Failed to load plugin 'ava' declared in 'BaseConfig » /usr/lib/node_modules/xo/config/plugins.js': Cannot find module 'eslint-plugin-ava'

npm list -g --depth 1 gives (for xo):

└─┬ [email protected]
  ├── @eslint/[email protected]
  ├── @typescript-eslint/[email protected]
  ├── @typescript-eslint/[email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  └── [email protected]

So eslint-plugin-ava is there, but something isn't working.

Require stack:
- <...>/__placeholder__.js
Referenced from: /usr/lib/node_modules/xo/config/plugins.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.resolve (internal/modules/cjs/helpers.js:80:19)
    at Object.resolve (/usr/lib/node_modules/xo/node_modules/@eslint/eslintrc/lib/shared/relative-module-resolver.js:28:50)
    at ConfigArrayFactory._loadPlugin (/usr/lib/node_modules/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:1017:39)
    at ConfigArrayFactory._loadExtendedPluginConfig (/usr/lib/node_modules/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:837:29)
    at ConfigArrayFactory._loadExtends (/usr/lib/node_modules/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:779:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/usr/lib/node_modules/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:720:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)
    at ConfigArrayFactory._normalizeObjectConfigData (/usr/lib/node_modules/xo/node_modules/@eslint/eslintrc/lib/config-array-factory.js:665:20)
    at _normalizeObjectConfigData.next (<anonymous>)

Originally posted by @AndrewMSHowe in #543 (comment)
@sindresorhus
Copy link
Member

// @Richienb

@Richienb
Copy link
Contributor

Richienb commented May 12, 2021 •
edited
Loading

There's no way to provide the absolute path of a plugin so I'm not quite sure how to fix it. The issue appears to have been present before xo 0.40.0 but Error: Failed to load config "xo" to extend from. would be thrown before it had a chance to be handled.

Perhaps it could be possible to set the cwd to a directory that can resolve the plugins and then compute the absolute paths of everything else but that would be opening a can of worms.

eslint/eslint#6237

@AndrewMSHowe
Copy link
Author

Is this happening because I'm installing xo globally? I'm sorry to report these problems :( I already have an eslint setup in my project directory so I thought installing xo globally (like in the docs) would allow me to try it.

@Richienb
Copy link
Contributor

Is this happening because I'm installing xo globally?

It is very likely the case. Try a local installation and see if it works.

@SiddharthShyniben
Copy link

I had this problem and a local install of xo fixed it

@AndrewMSHowe
Copy link
Author

I'll try it, it's just that I already have eslint and some plugins installed, and I'm worried that something's going to get messed up :(

@sindresorhus
Copy link
Member

@AndrewMSHowe Can you try running $ npx xo in your project?

@sindresorhus
Copy link
Member

@Richienb Maybe we could detect this case and add a human-friendly error message?

@AndrewMSHowe
Copy link
Author

OK weird so that asked me to install xo, and it has apparently put it somewhere other than global or in my project. It doesn't work because of some docker stuff that's mapped into my project folder. I would have to find a way around that. If I run it from a subdir with just source, it gives the same error about plugin 'ava' (I'm not using ava, but I guess it wants to load the plugin anyway). This time the error is Error: Failed to load plugin 'ava' declared in 'BaseConfig » /home/andrew/.npm/_npx/5b73490bd3e0c08a/node_modules/xo/config/plugins.js': Cannot find module 'eslint-plugin-ava' so I guess ~/.npm/_npx is where it ended up.
If you add an error message for global and npx usage then you will want to remove the --global from the Install section in the readme.md...

@AndrewMSHowe
Copy link
Author

Sorry I guess I need "npx xo" for local usage when I have installed xo locally rather than letting npx install it in its own stash, so that may have been misleading above.

@AndrewMSHowe
Copy link
Author

Anyway it does work locally, although I'm not sure how I will get it to work automatically in VSCode as well as my current setup.

@Richienb
Copy link
Contributor

Just discovered the resolvePluginsRelativeTo option which should be able to fix this. PR incoming soon.

@AndrewMSHowe
Copy link
Author

AndrewMSHowe commented Jun 18, 2021 •
edited
Loading

<gentle nudge> this stuff is also holding up the vscode plugin. Did you get anywhere with your PR?

@Richienb
Copy link
Contributor

As it turns out, fixing this problem causes another one to occur which has led me to conclude that resolvePluginsRelativeTo is not the solution.

@sindresorhus
Copy link
Member

Would you be able to elaborate what other problem it causes? For posterity.

@Richienb
Copy link
Contributor

The option doesn't let you specify multiple directories to resolve plugins from so that it would be possible to specify the node_modules where xo is installed and the node_modules of the current working directory at the same time.

Because it is also not possible to provide absolute paths as plugins, I don't see any good way to do this.

@sindresorhus
Copy link
Member

@Richienb Thanks for elaborating. It's seems we have hit a dead-end... Maybe it's worth opening an ESLint issue with a proposal with an option/API that could resolve this issue.

@Richienb
Copy link
Contributor

eslint/eslint#6237

@sindresorhus sindresorhus mentioned this issue Jul 1, 2021
Merged
@fisker fisker mentioned this issue Aug 8, 2021
Closed
@fisker
Copy link
Contributor

fisker commented Aug 8, 2021

@Richienb I didn't see you comment above before I send #589, can you explain what case won't work with the resolvePluginsRelativeTo option?

@fisker
Copy link
Contributor

fisker commented Aug 8, 2021

Did you mean install xo in a parent dir and install another plugin in a child dir, and run from child dir?

@Richienb
Copy link
Contributor

Richienb commented Aug 8, 2021

@Richienb I didn't see you comment above before I send #589, can you explain what case won't work with the resolvePluginsRelativeTo option?

When xo could still be installed globally, it was not possible to reference plugins from both the node_modules of xo and the node_modules of the project at hand. However, since xo removed global installation support, this might no longer be a problem.

@fisker
Copy link
Contributor

fisker commented Aug 9, 2021

Right, thanks.

@younho9 younho9 mentioned this issue Dec 7, 2021
Closed
This was referenced Aug 6, 2022
Closed
Closed
Closed
Closed
@fregante fregante changed the title Error: Failed to load plugin 'ava' declared in 'BaseConfig... Error: Failed to load plugin '*' declared in 'BaseConfig... Aug 6, 2022
@pepoirot pepoirot mentioned this issue Dec 4, 2022
Merged
@fregante fregante mentioned this issue Jan 4, 2023
Open
@bencmbrook bencmbrook mentioned this issue Jan 12, 2023
Merged
@fregante
Copy link
Member

I haven't seen this in a while. The problem in any case it's not in XO but in npm and eslint.

The solution is to do a fresh reinstall, without lockfile and node_modules.

It will eventually be resolved with the flat config:

@fregante fregante mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ESLint plugin load error fisker/xo
6 participants
@sindresorhus @fisker @fregante @AndrewMSHowe @Richienb @SiddharthShyniben