Issue with nan.h on windows (build fails)

[dadleyy]

I was having an issue where during the node-gyp rebuild process on my windows machine:

..\node-expat.cc(1): fatal error C1083: Cannot open include file: 'nan.h': No such file..

After running npm install nan --save I was still getting the issue, so I went into node-expat.cc and changed the include to be a relative path:

#include "node_modules/nan/nan.h"

Now everything is working fine.

It seems like this is more of an issue with node-gyp not updating the include_dirs in the build process on windows machines properly. Just wanted to make anyone who runs into this aware.

[lloydwatkin]

Thanks! This only got merged in this morning so good reactions.

Am testing out your fix here https://github.com/node-xmpp/node-expat/tree/dadleyy-nan-fix

Once travis comes back with a go/no go I'll merge as appropriate.

[lloydwatkin]

Ok, this change causes breakages on my current OS (OSX which was working before) and still fails on travis.

Therefore we need to find another solution to this. I'll add a note to the README.md for you though.

[jainsahab]

I got fatal error C1060: compiler is out of heap space. any idea regarding this error ?

[jeanru]

I had fatal error C1083:
\ucrt\corecrt.h(10): fatal error C1083: �޷��򿪰����ļ�: ��vcruntime.h��: No such file or directory (......\deps\libexpat\lib\xmlrole.c) [c:\Users\leon\AppData\Roaming\npm-cache\node_modules\node-expat\build\deps\libexpat\expat.vcxproj]