Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed VorbisConfig.cmake needs Ogg dependency #95

Open
madebr opened this issue Sep 26, 2022 · 0 comments
Open

Installed VorbisConfig.cmake needs Ogg dependency #95

madebr opened this issue Sep 26, 2022 · 0 comments

Comments

@madebr
Copy link

madebr commented Sep 26, 2022

An installed VorbisConfig.cmake needs Ogg

if(NOT TARGET Ogg::ogg)
find_dependency(Ogg REQUIRED)
endif()

This assumes ogg is installed with cmake and OggConfig.cmake/FindOgg.cmake is somehow available.

Vorbis itself ships a FindOgg.cmake module and thus does not require ogg to provide OggConfig.cmake.

So I propose to installFindOgg.cmake as well, and add it to CMAKE_MODULE_PATH inside VorbisConfig.cmake.

I do something similar in SDL_mixer to find the various dependencies.
(SDL_mixer only needs the dependencies when building a static library)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant