Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flac -t error codes should be more comprehensive #217

Open
smopucilowski opened this issue Jun 6, 2020 · 2 comments
Open

flac -t error codes should be more comprehensive #217

smopucilowski opened this issue Jun 6, 2020 · 2 comments

Comments

@smopucilowski
Copy link

Currently files which fail flac -t tests return the same error code: 1.

This arises from issue #192 in which MD5 warnings cannot be differentiated from other failures, subsequently making automation difficult.

@dlehammer
Copy link

1️⃣➕
Sounds sensible to me, it would also be very helpful if the approximate timestamp was included in the output, when attempting to debug decoding errors 🙏
(my guess is that the decoder knows which frame failed and could report that, but including a timestamp would provide a more relatable context for a novice like me 🤓 )

flac --test ~/18-INXS\ -\ Elegantly\ Wasted\(Shagsonic\ Remix\).flac

flac 1.4.3
Copyright (C) 2000-2009  Josh Coalson, 2011-2023  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

18-INXS - Elegantly Wasted(Shagsonic Remix).flac: *** Got error code 0:FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC


18-INXS - Elegantly Wasted(Shagsonic Remix).flac: ERROR during decoding
                                                  state = FLAC__STREAM_DECODER_END_OF_STREAM

((some cases seems related to #487 , where the new stricter decoder error might be triggered by meta-data - being able to distinguish different error sources would be most helpful))

@ktmf01
Copy link
Collaborator

ktmf01 commented Oct 16, 2024

You suggestions have recently already been added in #734.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants