Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fletcher?Array.__setitem__ doesn't preserve views #96

Closed
xhochy opened this issue Jan 9, 2020 · 2 comments
Closed

Fletcher?Array.__setitem__ doesn't preserve views #96

xhochy opened this issue Jan 9, 2020 · 2 comments
Labels
bug Something isn't working hackathon-2020-07 medium-complex Solvable without deep experise but not a good first issue

Comments

@xhochy
Copy link
Owner

xhochy commented Jan 9, 2020

TestBaseSetitemTests::test_setitem_preserves_views is failing as views don't update their parent on __setitem__.
@marco-neumann-by
Copy link

Views are an extremely tricky beast due to nested projections and all the slice parameters python allows. See https://github.com/JDASoftwareGroup/rle-array/blob/master/rle_array/_slicing.py for some useful helpers. In case you need them, we could probably extract them.

@xhochy xhochy added hackathon-2020-03 bug Something isn't working medium-complex Solvable without deep experise but not a good first issue labels Feb 21, 2020
@xhochy
Copy link
Owner Author

xhochy commented Feb 22, 2023

This project has been archived as development has ceased around 2021.
With the support of Apache Arrow-backed extension arrays in pandas, the major goal of this project has been fulfilled.

@xhochy xhochy closed this as completed Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working hackathon-2020-07 medium-complex Solvable without deep experise but not a good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xhochy @marco-neumann-by