Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context #26

Open
geoirb opened this issue Jan 23, 2021 · 7 comments
Open

Context #26

geoirb opened this issue Jan 23, 2021 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@geoirb
Copy link

geoirb commented Jan 23, 2021

Can you make connecting to the server and sending messages using context?

@xhit
Copy link
Owner

xhit commented Jan 24, 2021

Why? What thing can solve Context in this package?

@geoirb
Copy link
Author

geoirb commented Jan 25, 2021

@xhit Context will allow to more accurately control the connection to the server and sending messages, for example using context.WithTimeout

@xhit
Copy link
Owner

xhit commented Jan 25, 2021

Timeout is implemented to connect and to send.

@geoirb
Copy link
Author

geoirb commented Jan 25, 2021

I have seen that
The timeout for all submissions is the same, but if you add to post, the user can manage each posting

@xhit
Copy link
Owner

xhit commented Jan 27, 2021

The user can manage each posting.

I think Context, in this tiny package, solves nothing.

Maybe I'm wrong, and because I'm not fan of Context implementation because is like a virus and only add obscurity to the code.

I will left this issue open. I will accept a PR only if Context implementation can solve anything here.

@xhit xhit added the help wanted Extra attention is needed label Apr 29, 2021
@xhit
Copy link
Owner

xhit commented Nov 18, 2021

It's time to V3 so make all your ideas here: #53

@iamcalledrob
Copy link

Context support is important is to support cancellation, and would definitely be useful here. In case it's helpful to know, I'm choosing not to use this package due to the lack of context/cancellation support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants