Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CI #272

Closed
xhd2015 opened this issue Oct 25, 2024 · 2 comments
Closed

fix CI #272

xhd2015 opened this issue Oct 25, 2024 · 2 comments

Comments

@xhd2015
Copy link
Owner

xhd2015 commented Oct 25, 2024

Recent commits were seen with unstable CI results.

If there is unstable test case, then mark them skippable.
@xhd2015 xhd2015 mentioned this issue Nov 10, 2024
Merged
@xhd2015
Copy link
Owner Author

xhd2015 commented Nov 10, 2024

Currently some test fails randomly:

  • it may fail on windows but passes all other platforms
  • it may fail a particular go version but passes all other versions

Example:

image

This affects the quality of the unit tests.

A common failure is due to timeout:

image

These timeouts are usually related to traces.

@xhd2015
Copy link
Owner Author

xhd2015 commented Nov 10, 2024 •
edited
Loading

The trick is to detect output in stdout: panic: test timed out after

see https://github.com/xhd2015/xgo/pull/283/files#diff-47a0bd12304dfd48526d97fd8df232820531ec448006e51809d2ce9c585b055a

@xhd2015 xhd2015 closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xhd2015