Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toJSON() to Filter base class, implement or throw within FunctionFilter #3812

Open
amcclain opened this issue Oct 14, 2024 · 0 comments
Open
Labels

Comments

@amcclain
Copy link
Member

We can't actually serialize a function filter, but having toJSON() on the base class would be helpful and avoid cheats like:

filters: this.filters.map((f: any) => f.toJSON()),

which could then throw in an unhandled way.

Should we implement something human-readable, even if it could not be parsed back?

@amcclain amcclain added the data label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant