Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build FeedbackDialog and FeedbackDialogModel into XH #379

Closed
lbwexler opened this issue Jun 14, 2018 · 1 comment
Closed

Build FeedbackDialog and FeedbackDialogModel into XH #379

lbwexler opened this issue Jun 14, 2018 · 1 comment
Assignees
@febbraiod

Comments

@lbwexler
Copy link
Member

It seems weird that these are provided by Hoist, and the underlying service they rely on is provided by Hoist, but we don't wire them into XH by default.

Seems like if we think its a core part of the framework, there ought to be a one-line way for any app to display these. e.g. XH.showFeedbackDialog().
@lbwexler lbwexler changed the title Build FeedbackDialog and FeedbackDialogModel into Build FeedbackDialog and FeedbackDialogModel into XH Jun 14, 2018
@amcclain
Copy link
Member

As well as a standardized feedbackButton and built-in appBar support pls!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@febbraiod febbraiod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amcclain @lbwexler @febbraiod