Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional options for controlling alert banner visibility #3759

Open
amcclain opened this issue Aug 21, 2024 · 0 comments · May be fixed by #3764
Open

Additional options for controlling alert banner visibility #3759

amcclain opened this issue Aug 21, 2024 · 0 comments · May be fixed by #3764
Assignees

Comments

@amcclain
Copy link
Member

In addition to current expires and client apps filters in the admin alert banner spec, would like to add:

  • Limit to role(s)
    • Would allow a banner targeted to e.g. users of a particular section within the app, or internal users only (for an app that has a mix of internal company and external guest users)
  • Limit to app version
    • Would support easier banner takedown after e.g. a hotfix release. Could include convenience button for admin to populate with current version (this would be the expected use case) - banner will then automaticaallly not show right after release and refresh, without needing to get timing right or rush to remove immediately before/after
    • No need for fancy version ranges or anything like that - exact match should be all we need

Would group these together with existing client app field in a new "limit to" section.

@amcclain amcclain assigned jskupsik and jacob-xhio and unassigned jskupsik Aug 21, 2024
@jacob-xhio jacob-xhio linked a pull request Aug 22, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants