Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status monitor should not overwrite custom message with its generated one #268

Closed
amcclain opened this issue Sep 29, 2022 · 0 comments · Fixed by #269
Closed

Status monitor should not overwrite custom message with its generated one #268

amcclain opened this issue Sep 29, 2022 · 0 comments · Fixed by #269
Assignees
Labels

Comments

@amcclain
Copy link
Member

amcclain commented Sep 29, 2022

The status monitor API allows a check to set MonitorResult.message directly during execution, but MonitorResultService will overwrite that message in a variety of failure scenarios.

Sometimes the check might wish to use metric-driven evaluation (i.e. not set the result itself directly), but still has something useful to say even if the returned metrics eval to a failure.

To improve, the service could prepend its own generated message onto any message set by the check, instead of overwriting it completely. (I.e. the generated message is still useful / important, so show it in addition to any custom msg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants