Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to disable the Date Text and update the README #127

Merged
merged 2 commits into from
Jun 12, 2017

Conversation

avencat
Copy link
Contributor

@avencat avencat commented May 22, 2017

Added an option to disable the TextInput (hideText), added it to the README and fixed the README array

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.276% when pulling 8608531 on avencat:hideDateText into 2e63d0b on xgfe:master.

@feyy
Copy link
Contributor

feyy commented May 23, 2017

Thanks very much! But you can hide the text with style. Can your update the readme with another issue and using markdown only? Or I'll fix by myself.

@avencat
Copy link
Contributor Author

avencat commented May 23, 2017

Hi @feyy ! I've had some issue when trying to hide the icon with style only where the border stayed ! ;) So I managed to do this, it was the only way for me to disable the dateText... (I also followed #117)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.313% when pulling 0b20885 on avencat:hideDateText into 617b674 on xgfe:master.

@avencat
Copy link
Contributor Author

avencat commented May 24, 2017

@feyy Here what I get with:

customStyles={{
  dateInput: {
    borderStyle: null,
    height: 0,
    width: 0,
  }
}}

capture d ecran 2017-05-24 a 11 17 37

(I still get the little dot at the left)

But with this PR, as the textInput won't render anymore, I will be able to delete this little dot.

Is this possible to merge it ?

@avencat
Copy link
Contributor Author

avencat commented Jun 7, 2017

Hi @feyy! I've upgraded to react-native v0.45 and it seems that you can't hide the text with style anymore. Can you confirm that?

I get this:
capture d ecran 2017-06-07 a 19 23 36

with this style:

dateInput: {
  borderWidth: 0,
  borderStyle: null,
  height: 0,
  width: 0,
},

@avencat
Copy link
Contributor Author

avencat commented Jun 7, 2017

@feyy I've tested this PR on RN v0.45 and it works well. Could you merge this please ?

@feyy feyy merged commit 7c75cb0 into xgfe:master Jun 12, 2017
@avencat avencat deleted the hideDateText branch June 12, 2017 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants