Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colons can break quoting #102

Closed
talwrii opened this issue Jul 22, 2020 · 1 comment
Closed

Colons can break quoting #102

talwrii opened this issue Jul 22, 2020 · 1 comment

Comments

@talwrii
Copy link

talwrii commented Jul 22, 2020

Running this:

import graphviz

g = graphviz.Digraph("G")
g.edge(
    "a",
    "python:3.7@sha256:e8351629fe38c67486f92c818040f285e470faaaad6e15a46711fa7e380d7cdf",
)
print(str(g))

With graphviz 0.14.1 produces the following output

digraph G {
	a -> python:"3.7@sha256":e8351629fe38c67486f92c818040f285e470faaaad6e15a46711fa7e380d7cdf
}

I don't think this is quoted correctly.

@xflr6
Copy link
Owner

xflr6 commented Jul 22, 2020

Thanks for the report. I am assuming the result you expect is

"python:3.7@sha256:e8351629fe38c67486f92c818040f285e470faaaad6e15a46711fa7e380d7cdf"

(colons part of a quoted string with the node id).

We have the drawback that colons in node ids are currently not supported (due to how the support for node port and compass is implemented), so this works as documented. See #53 to track progress on lifting this (maybe adding support to use tuples to specify (node_id, port), (node_id,) and so on).

Duplicate of #53

@xflr6 xflr6 closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants