Skip to content

Commit ba6fa6f

Browse files
committed
use ignore_arg in all method decorators
1 parent f029709 commit ba6fa6f

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

graphviz/_tools.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def deprecate_positional_args(*,
129129
https://docs.python.org/3/library/exceptions.html#DeprecationWarning
130130
https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning
131131
"""
132-
assert supported_number > 0, f'supported_number at least one: {supported_number!r}'
132+
assert supported_number >= 0, f'supported_number => 0: {supported_number!r}'
133133

134134
if category is None:
135135
def nulldecorator(func):

graphviz/dot.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def _copy_kwargs(self, **kwargs):
143143
body=list(self.body),
144144
strict=self.strict)
145145

146-
@_tools.deprecate_positional_args(supported_number=1)
146+
@_tools.deprecate_positional_args(supported_number=0, ignore_arg='self')
147147
def clear(self, keep_attrs: bool = False) -> None:
148148
"""Reset content to an empty body, clear graph/node/egde_attr mappings.
149149
@@ -155,7 +155,7 @@ def clear(self, keep_attrs: bool = False) -> None:
155155
a.clear()
156156
self.body.clear()
157157

158-
@_tools.deprecate_positional_args(supported_number=1)
158+
@_tools.deprecate_positional_args(supported_number=0, ignore_arg='self')
159159
def __iter__(self, subgraph: bool = False) -> typing.Iterator[str]:
160160
r"""Yield the DOT source code line by line (as graph or subgraph).
161161
@@ -181,7 +181,7 @@ def __iter__(self, subgraph: bool = False) -> typing.Iterator[str]:
181181

182182
yield self._tail
183183

184-
@_tools.deprecate_positional_args(supported_number=3)
184+
@_tools.deprecate_positional_args(supported_number=2, ignore_arg='self')
185185
def node(self, name: str,
186186
label: typing.Optional[str] = None,
187187
_attributes=None, **attrs) -> None:
@@ -203,7 +203,7 @@ def node(self, name: str,
203203
line = self._node(name, attr_list)
204204
self.body.append(line)
205205

206-
@_tools.deprecate_positional_args(supported_number=4)
206+
@_tools.deprecate_positional_args(supported_number=3, ignore_arg='self')
207207
def edge(self, tail_name: str, head_name: str,
208208
label: typing.Optional[str] = None,
209209
_attributes=None, **attrs) -> None:
@@ -254,7 +254,7 @@ def edges(self, tail_head_iter) -> None:
254254
self.body += [edge(tail=quote(t), head=quote(h))
255255
for t, h in tail_head_iter]
256256

257-
@_tools.deprecate_positional_args(supported_number=2)
257+
@_tools.deprecate_positional_args(supported_number=1, ignore_arg='self')
258258
def attr(self, kw: typing.Optional[str] = None,
259259
_attributes=None, **attrs) -> None:
260260
"""Add a general or graph/node/edge attribute statement.
@@ -278,7 +278,7 @@ def attr(self, kw: typing.Optional[str] = None,
278278
line = self._attr(kw, attr_list)
279279
self.body.append(line)
280280

281-
@_tools.deprecate_positional_args(supported_number=2)
281+
@_tools.deprecate_positional_args(supported_number=1, ignore_arg='self')
282282
def subgraph(self, graph=None,
283283
name: typing.Optional[str] = None,
284284
comment: typing.Optional[str] = None,

graphviz/graphs.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class BaseGraph(dot.Dot,
4949
unflattening.Unflatten):
5050
"""Dot language creation and source code rendering."""
5151

52-
@_tools.deprecate_positional_args(supported_number=2)
52+
@_tools.deprecate_positional_args(supported_number=1, ignore_arg='self')
5353
def __init__(self, name: typing.Optional[str] = None,
5454
comment: typing.Optional[str] = None,
5555
filename=None, directory=None,

graphviz/piping.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def pipe(self,
109109
engine=engine,
110110
encoding=encoding)
111111

112-
@_tools.deprecate_positional_args(supported_number=2)
112+
@_tools.deprecate_positional_args(supported_number=1, ignore_arg='self')
113113
def _pipe_legacy(self,
114114
format: typing.Optional[str] = None,
115115
renderer: typing.Optional[str] = None,

graphviz/rendering.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
class Render(saving.Save, backend.Render, backend.View):
1919
"""Write source lines to file and render with Graphviz."""
2020

21-
@_tools.deprecate_positional_args(supported_number=2)
21+
@_tools.deprecate_positional_args(supported_number=1, ignore_arg='self')
2222
def render(self,
2323
filename: typing.Union[os.PathLike, str, None] = None,
2424
directory: typing.Union[os.PathLike, str, None] = None,
@@ -147,7 +147,7 @@ def _view(self, filepath: typing.Union[os.PathLike, str], *,
147147
f' on {backend.viewing.PLATFORM!r} platform')
148148
view_method(filepath, quiet=quiet)
149149

150-
@_tools.deprecate_positional_args(supported_number=2)
150+
@_tools.deprecate_positional_args(supported_number=1, ignore_arg='self')
151151
def view(self,
152152
filename: typing.Union[os.PathLike, str, None] = None,
153153
directory: typing.Union[os.PathLike, str, None] = None,

graphviz/unflattening.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
class Unflatten(encoding.Encoding, base.Base, backend.Unflatten):
1515
"""Pipe source through the Graphviz *unflatten* preprocessor."""
1616

17-
@_tools.deprecate_positional_args(supported_number=1)
17+
@_tools.deprecate_positional_args(supported_number=0, ignore_arg='self')
1818
def unflatten(self,
1919
stagger: typing.Optional[int] = None,
2020
fanout: bool = False,

0 commit comments

Comments
 (0)