Unexpected (?) behaviour of LocalVectorStore
's addMemories
#262
Labels
invalid
This doesn't seem right
LocalVectorStore
's addMemories
#262
I think that the current implementation of
addMemories
for theLocalVectorStore
class is not what we would expect. Namely, the actual code updates the previous state's memories asprevState.orderedMemories + memories.groupBy { it.conversationId }
, however, for a givenconversationId
it would just replace the list ofMemory
to the one in valuememories
, "forgetting" about the ones inprevState.orderedMemories
for that sameconversationId
. The following image shows the problem:The text was updated successfully, but these errors were encountered: