Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected (?) behaviour of LocalVectorStore's addMemories #262

Closed
victorcrrd opened this issue Jul 20, 2023 · 1 comment · Fixed by #260
Closed

Unexpected (?) behaviour of LocalVectorStore's addMemories #262

victorcrrd opened this issue Jul 20, 2023 · 1 comment · Fixed by #260
Assignees
Labels
invalid This doesn't seem right

Comments

@victorcrrd
Copy link
Contributor

I think that the current implementation of addMemories for the LocalVectorStore class is not what we would expect. Namely, the actual code updates the previous state's memories as prevState.orderedMemories + memories.groupBy { it.conversationId }, however, for a given conversationId it would just replace the list of Memory to the one in value memories, "forgetting" about the ones in prevState.orderedMemories for that same conversationId. The following image shows the problem:
Captura de pantalla 2023-07-20 a las 15 05 34

@victorcrrd victorcrrd added the invalid This doesn't seem right label Jul 20, 2023
@victorcrrd victorcrrd changed the title Unexpected behaviour of Memory Unexpected (?) behaviour of Memory Jul 20, 2023
@victorcrrd victorcrrd changed the title Unexpected (?) behaviour of Memory Unexpected (?) behaviour of LocalVectorStore's addMemories Jul 20, 2023
@javipacheco
Copy link
Contributor

Yes @victorcrrd

I saw the same problem this morning in my PR. I'm working on it

@javipacheco javipacheco linked a pull request Jul 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants