Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function _parse_builtin_densearray_attr fails when parsing a dense array with element_type IndexType #3154

Open
watermelonwolverine opened this issue Sep 10, 2024 · 1 comment
Open

Function _parse_builtin_densearray_attr fails when parsing a dense array with element_type IndexType #3154

watermelonwolverine opened this issue Sep 10, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@watermelonwolverine
Copy link
Contributor

The function _parse_builtin_densearray_attr does not accept dense arrays with element_type IndexType. On the other hand, the function DenseArrayBase.create_dense_int_or_index does accept IndexType as element_type.
@superlopuh superlopuh added good first issue Good for newcomers bug Something isn't working labels Sep 11, 2024
@superlopuh
Copy link
Member

Tagged as "good first issue", I expect resolving this is looking up what MLIR does for this, and making sure that both the functions do the expected thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@superlopuh @watermelonwolverine