Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--out casing changed with release 0.27 #1392

Closed
sosthene-nitrokey opened this issue Sep 26, 2023 · 3 comments · Fixed by #1395
Closed

--out casing changed with release 0.27 #1392

sosthene-nitrokey opened this issue Sep 26, 2023 · 3 comments · Fixed by #1395
Assignees

Comments

@sosthene-nitrokey
Copy link

This may not be a bug, but it's not mentioned the release notes or in the commit message that introduced this so I'm not sure it's intentional.

The casing of the arguments of the --out parameter changed with the migration to Clap v4 in d1bd48e. This means that old scripts using --out Html will fail (expecting --out html).
This is changed because ValueEnum defaults to kebab-case.

This is not necessarily a bug, but it is an undocumented breaking change.

If this is not intentional (or even if it is), I think it would be great to support both casing for a while to ease the transition, maybe with a deprecation warning. This makes it easier for scripts to migrate to the new version progressively.

@MiniaczQ
Copy link
Contributor

This is unintentional

@xd009642
Copy link
Owner

xd009642 commented Oct 2, 2023

reverted so it should work as before and releasing a new version as we speak

@sosthene-nitrokey
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants