Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing INSTALL_ROOT in qmake installation #240

Closed
atsampson opened this issue Sep 29, 2023 · 4 comments
Closed

Missing INSTALL_ROOT in qmake installation #240

atsampson opened this issue Sep 29, 2023 · 4 comments

Comments

@atsampson
Copy link

Thanks for adding the qmake install rules in version 4.3 - that's made life much simpler for packagers!

The custom install rule for the examples is currently written like this:

examples.extra = find examples -name \'*.xpf\' -exec cp {} $$PREFIX/share/XaoS/examples \;

This doesn't work if you've set INSTALL_ROOT (qmake's equivalent of what most build systems call DESTDIR) to install into a staging dir. Writing it this way generates a correct Makefile rule and fixes the problem for me:

examples.extra = find examples -name \'*.xpf\' -exec cp {} $(INSTALL_ROOT)$$PREFIX/share/XaoS/examples \;

It's not immediately obvious to me from the qmake docs whether you're allowed to refer to its make variables like this, though...

@kovzol
Copy link
Contributor

kovzol commented Sep 30, 2023

Thanks for this comment. Please do some research if this is widely used by others, that is, if it is at least a de facto standard. If yes, we'll do it similarly.

@leahneukirchen
Copy link

Pretty surely, note that the other install rules install into INSTALL_ROOT as well.

@leahneukirchen
Copy link

leahneukirchen commented Oct 5, 2023

There's also code missing to create this example directory, I think?

nvm: install_examples even creates it under INSTALL_ROOT, but then copies without INSTALL_ROOT.

@kovzol kovzol closed this as completed in 36aa53b Oct 6, 2023
@kovzol
Copy link
Contributor

kovzol commented Oct 6, 2023

Please let me know if that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants