Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot save image on Mac in 4.1pre1 #174

Closed
kovzol opened this issue Jun 26, 2020 · 5 comments · Fixed by #176, #177, #180 or #181
Closed

Cannot save image on Mac in 4.1pre1 #174

kovzol opened this issue Jun 26, 2020 · 5 comments · Fixed by #176, #177, #180 or #181
Assignees
@kanurag94
Labels
bug

Comments

@kovzol
Copy link
Contributor

kovzol commented Jun 26, 2020 •
edited
Loading

When using the DMG file, the XPF information is not saved in the PNG. The image is saved, however, correctly.
When XaoS is started from command line, the PNG is saved correctly (including the XPF information as well).
Maybe the temporary XPF file wants to be saved in a folder that is not writable. To avoid this, we should consider storing the XPF just in memory and not using the disk for this purpose at all.
@kanurag94 kanurag94 mentioned this issue Jun 27, 2020
Merged
@kanurag94 kanurag94 self-assigned this Jun 27, 2020
@kovzol kovzol reopened this Jun 28, 2020
@kovzol
Copy link
Contributor Author

kovzol commented Jun 28, 2020

Unfortunately the patch does not fix the issue.

@kovzol kovzol closed this as completed Jun 28, 2020
@kovzol kovzol reopened this Jun 28, 2020
@kanurag94
Copy link
Member

I am unable to reproduce this issue on Mac OS Catalina running with 4G ram, and core 2 duo. But I have compiled another version which may work. Can you please test this https://send.firefox.com/download/2ee9c3ca96cb4deb/#j9L-7An0QvNlYPkCk9sEDw

@kovzol
Copy link
Contributor Author

kovzol commented Jun 28, 2020 via email •
edited
Loading

@kanurag94 kanurag94 mentioned this issue Jun 28, 2020
Merged
@kovzol
Copy link
Contributor Author

kovzol commented Jun 30, 2020

I cannot reproduce this, but once I managed to see the same problem. Then the problem disappeared on the next attempt.

@kovzol kovzol reopened this Jun 30, 2020
@kovzol kovzol removed the blocker label Jun 30, 2020
@kanurag94 kanurag94 mentioned this issue Jul 1, 2020
Merged
@kanurag94
Copy link
Member

#180 resolves this issue.

@kanurag94 kanurag94 linked a pull request Jul 1, 2020 that will close this issue
Do not use temporarily an XPF file when saving/loading from a PNG #180
Merged
@kanurag94 kanurag94 mentioned this issue Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanurag94 kanurag94

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@kovzol @kanurag94