Skip to content
This repository was archived by the owner on Dec 10, 2024. It is now read-only.

Commit 912f9bf

Browse files
authored
Merge pull request #2062 from xanzy/metadata-proxy
Implement `externalK8sProxyUrl` field in Metadata API
2 parents 24eba26 + 29c7d05 commit 912f9bf

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

metadata.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ type Metadata struct {
3333
Version string `json:"version"`
3434
Revision string `json:"revision"`
3535
KAS struct {
36-
Enabled bool `json:"enabled"`
37-
ExternalURL string `json:"externalUrl"`
38-
Version string `json:"version"`
36+
Enabled bool `json:"enabled"`
37+
ExternalURL string `json:"externalUrl"`
38+
ExternalK8SProxyURL string `json:"externalK8sProxyUrl"`
39+
Version string `json:"version"`
3940
} `json:"kas"`
4041
Enterprise bool `json:"enterprise"`
4142
}

metadata_test.go

+10-7
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ func TestGetMetadata(t *testing.T) {
3535
"enterprise": true,
3636
"kas": {
3737
"enabled": true,
38-
"externalUrl": "wss://kas.gitlab.com",
38+
"externalUrl": "wss://kas.gitlab.example.com",
39+
"externalK8sProxyUrl": "https://kas.gitlab.example.com/k8s-proxy",
3940
"version": "15.6.0-rc2"
4041
}
4142
}`)
@@ -48,13 +49,15 @@ func TestGetMetadata(t *testing.T) {
4849

4950
want := &Metadata{
5051
Version: "15.6.0-pre", Revision: "016e8d8bdc3", KAS: struct {
51-
Enabled bool `json:"enabled"`
52-
ExternalURL string `json:"externalUrl"`
53-
Version string `json:"version"`
52+
Enabled bool `json:"enabled"`
53+
ExternalURL string `json:"externalUrl"`
54+
ExternalK8SProxyURL string `json:"externalK8sProxyUrl"`
55+
Version string `json:"version"`
5456
}{
55-
Enabled: true,
56-
ExternalURL: "wss://kas.gitlab.com",
57-
Version: "15.6.0-rc2",
57+
Enabled: true,
58+
ExternalURL: "wss://kas.gitlab.example.com",
59+
ExternalK8SProxyURL: "https://kas.gitlab.example.com/k8s-proxy",
60+
Version: "15.6.0-rc2",
5861
},
5962
Enterprise: true,
6063
}

0 commit comments

Comments
 (0)