From 1a582ed59a02193619dae8c245648756fcdd45a7 Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Thu, 10 Sep 2020 16:01:19 +0200 Subject: [PATCH] [tests] Ignore a few link sdk tests in .NET for now. (#9614) There are easier fish to fry right now, so implementing the linker support for these tests to pass (metadata reduction and code removal) can wait. This makes the link sdk/Release variation green for .NET. Ref: https://github.com/xamarin/xamarin-macios/issues/9612 Ref: https://github.com/xamarin/xamarin-macios/issues/9613 --- tests/linker/ios/link sdk/LinkSdkRegressionTest.cs | 3 +++ tests/linker/ios/link sdk/ReflectionTest.cs | 3 +++ tests/xharness/Harness.cs | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/linker/ios/link sdk/LinkSdkRegressionTest.cs b/tests/linker/ios/link sdk/LinkSdkRegressionTest.cs index 4b5df51324f1..2a71a265b5bd 100644 --- a/tests/linker/ios/link sdk/LinkSdkRegressionTest.cs +++ b/tests/linker/ios/link sdk/LinkSdkRegressionTest.cs @@ -990,6 +990,9 @@ public void SecurityDeclaration () static Type type_uibutton = typeof (UIButton); [Test] +#if NET + [Ignore ("Not implemented yet: https://github.com/xamarin/xamarin-macios/issues/9612")] +#endif public void UIButtonSubclass () { // ensure the linker keeps the .ctor(UIButtonType) around diff --git a/tests/linker/ios/link sdk/ReflectionTest.cs b/tests/linker/ios/link sdk/ReflectionTest.cs index 475f99c7ed3e..277cc25d4c16 100644 --- a/tests/linker/ios/link sdk/ReflectionTest.cs +++ b/tests/linker/ios/link sdk/ReflectionTest.cs @@ -16,6 +16,9 @@ public void MethodWithParameters (string firstParameter, int secondParameter) { } +#if NET + [Ignore ("Metadata reduction not implemented yet: https://github.com/xamarin/xamarin-macios/issues/9612")] +#endif [Test] public void ParameterInfoName () { diff --git a/tests/xharness/Harness.cs b/tests/xharness/Harness.cs index c7d2f8e5c56b..d8a0809be1c4 100644 --- a/tests/xharness/Harness.cs +++ b/tests/xharness/Harness.cs @@ -397,7 +397,7 @@ void AutoConfigureIOS () IOSTestProjects.Add (new iOSTestProject (Path.GetFullPath (Path.Combine (RootDirectory, "linker", "ios", "link all", "link all.csproj"))) { Configurations = new string [] { "Debug", "Release" } }); IOSTestProjects.Add (new iOSTestProject (Path.GetFullPath (Path.Combine (RootDirectory, "linker", "ios", "link all", "dotnet", "iOS", "link all.csproj"))) { Configurations = new string [] { "Debug" /*, "Release" */ }, IsDotNetProject = true, SkipiOSVariation = false, SkiptvOSVariation = true, SkipwatchOSVariation = true, SkipTodayExtensionVariation = true, SkipDeviceVariations = true, SkipiOS32Variation = true }); IOSTestProjects.Add (new iOSTestProject (Path.GetFullPath (Path.Combine (RootDirectory, "linker", "ios", "link sdk", "link sdk.csproj"))) { Configurations = new string [] { "Debug", "Release" } }); - IOSTestProjects.Add (new iOSTestProject (Path.GetFullPath (Path.Combine (RootDirectory, "linker", "ios", "link sdk", "dotnet", "iOS", "link sdk.csproj"))) { Configurations = new string [] { "Debug" /*, "Release" */ }, IsDotNetProject = true, SkipiOSVariation = false, SkiptvOSVariation = true, SkipwatchOSVariation = true, SkipTodayExtensionVariation = true, SkipDeviceVariations = true, SkipiOS32Variation = true }); + IOSTestProjects.Add (new iOSTestProject (Path.GetFullPath (Path.Combine (RootDirectory, "linker", "ios", "link sdk", "dotnet", "iOS", "link sdk.csproj"))) { Configurations = new string [] { "Debug", "Release" }, IsDotNetProject = true, SkipiOSVariation = false, SkiptvOSVariation = true, SkipwatchOSVariation = true, SkipTodayExtensionVariation = true, SkipDeviceVariations = true, SkipiOS32Variation = true }); foreach (var flavor in new MonoNativeFlavor [] { MonoNativeFlavor.Compat, MonoNativeFlavor.Unified }) { var monoNativeInfo = new MonoNativeInfo (DevicePlatform.iOS, flavor, RootDirectory, Log);