[Xamarin.Android.Build.Tasks] combine CheckTargetFrameworks/ResolveAssemblies #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Sep 11, 2018
|
This saves 77ms. We should mention the savings in the commit messages so I can do less math. :-) |
…semblies Context: https://gist.github.com/jonathanpeppers/a207a8828317460239a12a8b0cc918d7 When reviewing how many times we are using Mono.Cecil to open every assembly, it was happening 9 times! Unfortunately it is not as easy as just "caching" something, the simplest approach for now is to start combining functionality that are in multiple tasks right now. A simple first example is the `CheckTargetFrameworks` MSBuild task, which runs after the `Compile` and `ResolveAssemblies` MSBuild tasks. `CheckTargetFrameworks` has the job of emitting warnings about `[assembly: System.Runtime.Versioning.TargetFramework]`. We can easily do this work in `ResolveAssemblies` as it is already looping over all the assemblies' custom attributes for other reasons. Changes to make this happen: - Removed `CheckTargetFrameworks` and the `_CheckTargetFrameworks` target, adding the required `TargetFrameworkVersion` and `ProjectFile` properties to `ResolveAssemblies`. - Added a new `CheckAssemblyAttributes` where we can add to a `switch` statement for new attribute types in the future as needed. - Added a dictionary of `api_levels`, and copied over the logic from `CheckTargetFrameworks` Before: 105 ms CheckTargetFrameworks 1 calls 188 ms ResolveAssemblies 1 calls After: 216 ms ResolveAssemblies 1 calls I timed the `tests/Xamarin.Forms-Performance-Integration` project in this repository: a build with no changes. Since `CheckTargetFrameworks` is removed completely, we can avoid the time it was taking to open every assembly again. This saves around 77ms.
jonathanpeppers
force-pushed
the
checktargetframeworks-resolveassemblies
branch
from
dc0d04f to
8e54441
Compare
|
I updated the commit message, since the macOS build hadn't started yet. I also mentioned what project, and that it was a build with no changes. Build logs here: CheckTargetFrameworks.zip |
|
Weird build error. |
|
build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://gist.github.com/jonathanpeppers/a207a8828317460239a12a8b0cc918d7
When reviewing how many times we are using Mono.Cecil to open every
assembly, it was happening 9 times!
Unfortunately it is not as easy as just "caching" something, the
simplest approach for now is to start combining functionality that are
in multiple tasks right now.
A simple first example is the
CheckTargetFrameworksMSBuild task,which runs after the
CompileandResolveAssembliesMSBuild tasks.CheckTargetFrameworkshas the job of emitting warnings about[assembly: System.Runtime.Versioning.TargetFramework]. We can easilydo this work in
ResolveAssembliesas it is already looping over allthe assemblies' custom attributes for other reasons.
Changes to make this happen:
CheckTargetFrameworksand the_CheckTargetFrameworkstarget, adding the required
TargetFrameworkVersionandProjectFileproperties toResolveAssemblies.CheckAssemblyAttributeswhere we can add to aswitchstatement for new attribute types in the future as needed.
api_levels, and copied over the logic fromCheckTargetFrameworksBefore:
After:
I timed the
tests/Xamarin.Forms-Performance-Integrationproject inthis repository: a build with no changes.
Since
CheckTargetFrameworksis removed completely, we can avoid thetime it was taking to open every assembly again.
This saves around 77ms.