Marking constant fields that will be removed in the next version as Obsolete error #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gugavaro
force-pushed
the
gugavaro_ji_deprecatedfields
branch
from
a263755
to
75d0378
Compare
gugavaro
force-pushed
the
gugavaro_ji_deprecatedfields
branch
from
75d0378
to
1a4d2ea
Compare
jonpryor
pushed a commit
that referenced
this pull request
Feb 19, 2020
Context: #509 Context: dotnet/android#4248 We are generating fields that have been marked as `[Obsolete]` for a long time. In the effort to remove all fields that now we believe should not be part of our API, we are marking them as `[Obsolete(..., error:true)]` so we can remove them in a future release. Here are some scenarios these changes are addressing: We should `[Obsolete(error:true)]` *fields* on "interface proxy" types such as [`Android.Content.ComponentCallbacks2`][0], which contains fields for the [`android.content.ComponentCallbacks2`][1] interface and lives "alongside" the [Android.Content.IComponentCallbacks2][2] interface. Additionally, all of these fields should *eventually* be moved into the appropriate C# interface via Default Interface Members, e.g. every field within `Android.Content.ComponentCallbacks2` should *instead* reside in the `Android.Content.IComponentCallbacks2` type. TODO: * We should `[Obsolete(error:true)]` the interface proxy types themselves. * We also `[Obsolete(error:true)]` all of the nested `InterfaceConsts` types, such as `Android.OS.Binder.InterfaceConsts`. * We should also `[Obsolete(error:true)]` all members which are already [Obsolete]. [0]: https://docs.microsoft.com/en-us/dotnet/api/android.content.componentcallbacks2?view=xamarin-android-sdk-9 [1]: https://developer.android.com/reference/android/content/ComponentCallbacks2 [2]: https://docs.microsoft.com/en-us/dotnet/api/android.content.icomponentcallbacks2?view=xamarin-android-sdk-9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are generating fields that have been marked as obsolete for a long time.
In the effort to remove all fields that now we believe should not be part of our API, we are marking then as obsolete Error=True so we can remove them in the next release.
Here are some scenarios these changes are addressing:
We should [Obsolete(error:true)] "interface proxy" types such as Android.Content.ComponentCallbacks2, which contains fields for the android.content.ComponentCallbacks2 interface and lives "alongside" the Android.Content.IComponentCallbacks2 interface. Additionally, all of these fields should be moved into the appropriate C# interface, e.g. every field within Android.Content.ComponentCallbacks2 should reside in the Android.Content.IComponentCallbacks2 type, using C#8 default interface members.
We should also [Obsolete(error:true)] all of the nested InterfaceConsts types, such as Android.OS.Binder.InterfaceConsts.
We should also [Obsolete(error:true)] all members which are already [Obsolete].
This PR should be combined with XA PR: dotnet/android#4248