This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Implementing Rolf's suggestion to fix clang/math.h issue #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
approved these changes
Nov 11, 2020
stephen-hawley
approved these changes
Nov 11, 2020
chamons
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR Rolf suggested to cherry-pick this change: swiftlang#32436.
Towards the end of that PR, the author mentions a different fix that gives "better isolation" here and I implemented this one. Tried locally and it worked!
This will allow us not to have to modify Xcode files like I was doing here
I tried to cherry pick this change, but apple merged this change to their master branch that no longer shows up in apple/swift so I just implemented the change.