Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[Bug] Bad scaling on UWP toolbar icons with FontImageSource (Forms 4.4.0) #8866

Open
MitchBomcanhao opened this issue Dec 12, 2019 · 6 comments

Comments

@MitchBomcanhao
Copy link

MitchBomcanhao commented Dec 12, 2019

Description

UWP Toolbar items have been slightly tweaked recently and display larger buttons with a slightly larger image. In my case, I use a FontImageSource and have noticed that the quality of the rendering of said image has worsened in this new version.

Steps to Reproduce

  1. Add a toolbar item with a FontIconSource

Expected Behavior

The icon is rendered appropriately when the app runs.

Actual Behavior

The icon is badly scaled.

Basic Information

  • Version with issue: 4.4.0.991265
  • Last known good version: 4.2.0 (sort of), they're all bad but has gotten worse now.
  • IDE: 16.3.9
  • Platform Target Frameworks:
    • UWP: 18362

Screenshots

image

As you can see in the image above, the 4.2.0 rendering was small but actually displayed more detail - the 4.4.0 version is missing tons of detail even though it is larger.

For reference, I've added the exact same FontIconSource on a button image so that you can see how it looks like.

Reproduction Link

Issue8866.zip

Issue8866withMasterDetail.zip

@MitchBomcanhao MitchBomcanhao added s/unverified New report that has yet to be verified t/bug 🐛 labels Dec 12, 2019
@kingces95
Copy link
Contributor

Could you please attach a zipped reproduction of the solution/project?

@kingces95 kingces95 added the s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. label Dec 13, 2019
@MitchBomcanhao
Copy link
Author

MitchBomcanhao commented Dec 16, 2019

@kingces95

I've attached a couple of repro projects in the original post.
While making the repro project, I have found more issues with this, ie
The size of toolbar items is different if you use a MasterDetail or a regular NavigationPage. MasterDetail will make the toolbar items larger to fill the navigation bar, whereas the standard NavigationPage will not.

They both render the icons in a worse way in 4.4.0, though, so that bit is consistent.

4.2.0
image
image

4.4.0
image
image

@MitchBomcanhao
Copy link
Author

MitchBomcanhao commented Dec 16, 2019

Wondering if the issue is related to PR #8147

@samhouts samhouts added i/regression p/UWP and removed s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. labels Dec 17, 2019
@samhouts samhouts added this to the 4.4.0 milestone Dec 17, 2019
@samhouts samhouts added e/3 🕒 3 and removed s/unverified New report that has yet to be verified labels Dec 31, 2019
@nschoenberg
Copy link

@MitchBomcanhao I also have this issue since recent update of XF. I also have the problem that on minimizing the app and bringing it back to front hides the toolbar icon. Same for you?

@MitchBomcanhao
Copy link
Author

@nschoenberg I've not seen that disappearing issue myself, but i've seen it reported here: is this what you're having? see: #10168

@samhouts samhouts added the 4.4.0 regression on 4.4.0 label Apr 14, 2020
@nschoenberg
Copy link

@MitchBomcanhao Uh wow thanks for pointing me into direction of #10168 - Really sounds like the issue I have but I can't confirm the 15 seconds, it's less then that. But yea seems already fixed so I will try again

@samhouts samhouts removed this from the 4.4.0 milestone Apr 17, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants