Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better combat animations showing sword double #59

Closed
kiishiio opened this issue Mar 8, 2024 · 5 comments
Closed

better combat animations showing sword double #59

kiishiio opened this issue Mar 8, 2024 · 5 comments

Comments

@kiishiio
Copy link

kiishiio commented Mar 8, 2024

I see my first person player model doing the attack animation + the better combat hand animation.
theres no way to disable the better combat item from rendering.
[using realcamera-0.6.0-alpha.2]

video showcasing the problem:
https://drive.google.com/file/d/1ADCL5M0I7HRXqOz0qWtbShYdrg1hsyz8/view?usp=sharing

@xTracr
Copy link
Owner

xTracr commented Mar 8, 2024

In fact, 0.6.0-beta hasn't been released in these days is because this issue
If this is solved, shadow would not be rendered when using shaders
1 20 1-fabric_2024-03-08 18-25-17
I read the source code of Better Combat and Iris then, and I think it would be better for the author of Better Combat to handle the issue
just need to do the same as for compatibility with First Person Model

But it would be faster if I fix
since Better Combat's last commit was two months ago

@xTracr
Copy link
Owner

xTracr commented Mar 8, 2024

I have just fixed it by simply modifying the value of a field in the code of Better Combat
snapshot

@Turker9002
Copy link

a little confused, how do i fix it :(

@RavensVanity
Copy link

I see my first person player model doing the attack animation + the better combat hand animation. theres no way to disable the better combat item from rendering. [using realcamera-0.6.0-alpha.2]

video showcasing the problem: https://drive.google.com/file/d/1ADCL5M0I7HRXqOz0qWtbShYdrg1hsyz8/view?usp=sharing

Hey, I was hoping you could tell me how you fixed this. Thanks in advance :) Hope to hear from you soon

@kiishiio
Copy link
Author

sorry for writing so late and that i didnt answer the previous question,
i no longer play minecraft so i cant tell for sure.
but i believe i fixed it by testing different alpha versions around the mentioned version.
i think in some versions there was an option for compat with better combat.

i found some of the mods i was using back then, i dont know if they were the latest as i dont have that modpack anymore.
version i used of realcamera: 1.20.1-fabric-0.6.0-beta || config: https://pastebin.com/tSYK929M
version i used for bettercombat: fabric-1.8.4+1.20.1 || config: https://pastebin.com/NRxs6Brs (client) | https://pastebin.com/N9NaEAuA (server)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants