-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPP Connect sometimes falsely detects if a file needs to be uploaded #4972
Comments
Dev Investigation: FPP.CheckMediaUpload relevant code:
mp3 gain probably matches the size still (?) but perhaps we need a checksum..... |
Is there anything else relevent in the json being returned for the media? This may require a change upstream in order to make use of it. |
Good callout. Sample Response for an MP3 from FPP REST call to I dont see a checksum or anything that could work - if FPP would generate and return a checksum, then we could diff it. (Can't use the Amazon checksum that is there as it's more of meta-metadata and not a guarantee) |
One more... If you FPP MP3Gain it.. anything in that response change? |
The reverse is a feature then ... if you mp3gain it on FPP then fpp connect will NOT upload a new version and overwrite your MP3Gain done on FPP. I never knew that. |
So frankly the mp3 side of this is not really a big deal, for the once a season cleaning out the audio files, and re-upload. |
Are you using hostnames for your controller(s)/FPP or strictly IPs? |
strictly IP's. The other two users who I've seen the fseq behavior with were also only IPs |
Might be worth attaching a tools->package logs |
K, I'll get one, along with an approximate time of when the issue occurred, because they are support driven, it may take me a bit to obtain. |
disregard todays post, that was user error |
Describe the bug
Sometimes while running FPP connect files that the user expects to have been updated on the controller have not been.
To Reproduce
Steps to reproduce the behavior:
(and/or link to a short video showing the problem with audio track describing what you are doing)
I'm going to use this as an example as it's easy to duplicate, but this also happens with changed fseq files, in a manner I'm unable to properly duplicate
To correct:
Expected behavior
For FPP Connect to update changed files that differ from the sequencing computer
Screenshots
Happy to add these, but expect you know what FPP connect window looks like. :)
Versions (please complete the following information):
Additional context
I wasn't sure whether to post this to xlights or fpp github as an issue, happy to move it if you think that's the right thing to do.
Deleting the files in question from FPP and then re-uploading works. I'm aware that mp3 gain specifically may make it hard to detect the file has changed, depending on the detection method, but as I said it happens (less frequently) when trying to troubleshoot channel scramble with a user, you'll watch them do an FPP connect, the problem still exists, and you can go and look at FPP and see the mtime on the remote file is different than the local file. delete the file in question and re-upload and the problem is fixed
Perhaps if fixing the file change detection is challenging, as a workaround a force overwrite checkbox could be deployed inside of FPP Connect to bypass the detection if the file requires overwriting, and remove the need to go find the file and delete it?
Attachments
The text was updated successfully, but these errors were encountered: