Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEF will not automatically generate language files in the lang folder #178

Closed
haha44444 opened this issue Jan 11, 2024 · 15 comments
Closed

Comments

@haha44444
Copy link

same as title.
It will only generate a lang folder but not the files inside.

server version: Kaiiju version git-Kaiiju-"93f3978" (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 93f3978 on ver/1.19.4)
(this is a Folia fork)

AEF version: v2.6.0

@ghost
Copy link

ghost commented Jan 11, 2024

i dont see this problem on Kaiiju

@xGinko
Copy link
Owner

xGinko commented Jan 11, 2024

Whats the language/locale the server machine is on?

@ghost
Copy link

ghost commented Jan 11, 2024

[23:37:56 INFO]: This server is running Kaiiju version git-Kaiiju-"c2b7aec" (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: c2b7aec on ver/1.20.1)

last kaiiju from release

@haha44444
Copy link
Author

Whats the language/locale the server machine is on?

Simplified Chinese/China

@xGinko
Copy link
Owner

xGinko commented Jan 11, 2024

Weird, BetterWorldStats uses the exact same lang loader line by line and it worked.

@haha44444
Copy link
Author

Weird, BetterWorldStats uses the exact same lang loader line by line and it worked.

yes, it works

@xGinko
Copy link
Owner

xGinko commented Jan 11, 2024

On a local test machine of Kaiiju 1.19.4 as well as 1.20.1, all files could successfully be generated. I would blame it on File.separator but usage of that should actually fix pathing problems across multiple system locales and its also used in BetterWorldStats.

I would believe it has to do with something on your end as I cannot reproduce this.

If you can, please conduct some testing

@haha44444
Copy link
Author

On a local test machine of Kaiiju 1.19.4 as well as 1.20.1, all files could successfully be generated. I would blame it on File.separator but usage of that should actually fix pathing problems across multiple system locales and its also used in BetterWorldStats.

I would believe it has to do with something on your end as I cannot reproduce this.

If you can, please conduct some testing

I changed my language and region to english/us but it still doesn't work

@xGinko
Copy link
Owner

xGinko commented Jan 11, 2024

On a local test machine of Kaiiju 1.19.4 as well as 1.20.1, all files could successfully be generated. I would blame it on File.separator but usage of that should actually fix pathing problems across multiple system locales and its also used in BetterWorldStats.
I would believe it has to do with something on your end as I cannot reproduce this.
If you can, please conduct some testing

I changed my language and region to english/us but it still doesn't work

Yea like I pointed out, its most likely not your locale setting

@haha44444
Copy link
Author

On a local test machine of Kaiiju 1.19.4 as well as 1.20.1, all files could successfully be generated. I would blame it on File.separator but usage of that should actually fix pathing problems across multiple system locales and its also used in BetterWorldStats.
I would believe it has to do with something on your end as I cannot reproduce this.
If you can, please conduct some testing

I changed my language and region to english/us but it still doesn't work

Yea like I pointed out, its most likely not your locale setting

I tested it and it works on ubuntu22.04lts, the unavailable systems are windows11 22h2 and windows10 21h2

@xGinko
Copy link
Owner

xGinko commented Jan 11, 2024

It should go without saying that windows is the opposite of a recommended server os

@haha44444
Copy link
Author

haha44444 commented Jan 11, 2024

It should go without saying that windows is the opposite of a recommended server os

i know. i will not use windows to run the minecraft server in a production environment, but sometimes, such as when debugging, I will use windows.

@xGinko
Copy link
Owner

xGinko commented Jan 11, 2024

I will do some testing to see what causes this on windows. Generally though you should always test in an environment similar to the one in production.

Priority will be low for this so don't expect anything soon

@haha44444
Copy link
Author

After testing, this problem will also occur on Windows Server 2019.

@xGinko
Copy link
Owner

xGinko commented Feb 27, 2024

Fixed thanks to testing by @F3F5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants