Skip to content

Commit e601e2a

Browse files
committed
ENH more precise instruction for PR
1 parent 2509e24 commit e601e2a

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Assignment 2 for the DataCamp course X-DataScience Master
1+
# Assignment 2 for the DataCamp course X-DataScience Master - pandas
22

33
## What we want you to learn by doing this assignment:
44

@@ -12,9 +12,14 @@
1212

1313
- Fork the repository by clicking on the `Fork` button on the upper right corner
1414
- Clone the repository of your fork with: `git clone https://github.com/MYLOGIN/datacamp-assignment-pandas` (replace MYLOGIN with your GitHub login)
15-
- Create a branch called `myassignment` using `git checkout -b myassignment`
15+
- Create a branch called `MYLOGIN` using `git checkout -b MYLOGIN`
1616
- Make the changes to complete the assignment. You have to modify the files that contain `questions` in their name. Do not modify the files that start with `test_`.
17-
- Open the pull request on GitHub
17+
- Check locally that your solution meet the test by running `pytest` from the root of the repo. You may need to install `pytest` using `pip` or `conda`.
18+
- Check the code formating for your solution using `flake8`. You may need to install `flake8` using `pip` or `conda`.
19+
- Open the pull request on GitHub:
20+
- Create a commit with `git add -u` and `git commit -m "UP my solution"`
21+
- Push your branch on your fork: `git push -u origin MYLOGIN`
22+
- Go to your repo in your browser and click the `Open a PR` button.
1823
- Keep pushing to your branch until the continuous integration system is green.
1924
- When it is green notify the professors on Slack that your done.
2025

0 commit comments

Comments
 (0)