refactor to fix codeclimate issue

wurmlab · Aug 5, 2023 · 8ddf164 · 8ddf164
1 parent 10fb5be
commit 8ddf164
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 23 deletions.
diff --git a/public/js/sidebar.js b/public/js/sidebar.js
@@ -1,4 +1,4 @@
-import { Component } from 'react';
+import React, { Component } from 'react';
 import _ from 'underscore';
 
 import downloadFASTA from './download_fasta';
@@ -353,6 +353,7 @@ export default class extends Component {
     }
 
     sharingPanelJSX() {
+        const link_class = 'btn-link cursor-pointer';
         return (
             <div className="sharing-panel">
                 <div className="section-header-sidebar">
@@ -361,29 +362,30 @@ export default class extends Component {
                     </h4>
                 </div>
                 <ul className="nav">
-                    {!this.props.cloudSharingEnabled ?
-                        <>
-                            <li>
-                                <a id="copyURL" className="btn-link copy-URL cursor-pointer" data-toggle="tooltip"
-                                    onClick={this.copyURL}>
-                                    <i className="fa fa-copy"></i> Copy URL to clipboard
-                                </a>
-                            </li>
+                    {
+                        !this.props.cloudSharingEnabled ?
+                            <React.Fragment>
+                                <li>
+                                    <a id="copyURL" className={`${link_class} copy-URL`} data-toggle="tooltip"
+                                        onClick={this.copyURL}>
+                                        <i className="fa fa-copy"></i> Copy URL to clipboard
+                                    </a>
+                                </li>
+                                <li>
+                                    <a id="sendEmail" className={`${link_class} email-URL`} data-toggle="tooltip"
+                                        title="Send by email" href={asMailtoHref(this.props.data.querydb, this.props.data.program, this.props.data.queries, window.location.href)}
+                                        target="_blank" rel="noopener noreferrer">
+                                        <i className="fa fa-envelope"></i> Send by email
+                                    </a>
+                                </li>
+                            </React.Fragment> :
                             <li>
-                                <a id="sendEmail" className="btn-link email-URL cursor-pointer" data-toggle="tooltip"
-                                    title="Send by email" href={asMailtoHref(this.props.data.querydb, this.props.data.program, this.props.data.queries, window.location.href)}
-                                    target="_blank" rel="noopener noreferrer">
-                                    <i className="fa fa-envelope"></i> Send by email
-                                </a>
-                            </li>
-                        </> :
-                        <li>
-                            <button className="btn-link cloud-Post cursor-pointer" data-toggle="tooltip"
-                                title="Upload results to SequenceServer Cloud where it will become accessable
+                                <button id="shareToCloud" className={`${link_class} cloud-Post`} data-toggle="tooltip"
+                                    title="Upload results to SequenceServer Cloud where it will become accessable
                                 to everyone who has a link." onClick={this.shareCloudInit}>
-                                <i className="fa fa-cloud"></i> Share to cloud
-                            </button>
-                        </li>
+                                    <i className="fa fa-cloud"></i> Share to cloud
+                                </button>
+                            </li>
                     }
                 </ul>
                 {