From e2b851699cfd34a43a5b7ebdef2c6007a1d05950 Mon Sep 17 00:00:00 2001 From: Dominik Korittki <23359034+dkorittki@users.noreply.github.com> Date: Mon, 6 Oct 2025 13:15:51 +0200 Subject: [PATCH 1/2] fix: Add missing subscription updater methods --- .../graphql_datasource/graphql_datasource_test.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go b/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go index 1077daa1ad..f6c67ce53e 100644 --- a/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go +++ b/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go @@ -8331,6 +8331,16 @@ func (t *testSubscriptionUpdater) Close(kind resolve.SubscriptionCloseKind) { t.closed = true } +func (t *testSubscriptionUpdater) CloseSubscription(kind resolve.SubscriptionCloseKind, id resolve.SubscriptionIdentifier) { +} + +func (t *testSubscriptionUpdater) Subscriptions() map[context.Context]resolve.SubscriptionIdentifier { + return make(map[context.Context]resolve.SubscriptionIdentifier) +} + +func (t *testSubscriptionUpdater) UpdateSubscription(id resolve.SubscriptionIdentifier, data []byte) { +} + func TestSubscriptionSource_Start(t *testing.T) { chatServer := httptest.NewServer(subscriptiontesting.ChatGraphQLEndpointHandler()) defer chatServer.Close() From 9d03e77558aec0e06674eaade7fb1ae1720dd7ab Mon Sep 17 00:00:00 2001 From: Dominik Korittki <23359034+dkorittki@users.noreply.github.com> Date: Mon, 6 Oct 2025 14:21:48 +0200 Subject: [PATCH 2/2] chore: add docs for context --- .../datasource/graphql_datasource/graphql_datasource_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go b/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go index f6c67ce53e..72848e9dd5 100644 --- a/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go +++ b/v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go @@ -8251,7 +8251,6 @@ func (f *FailingSubscriptionClient) SubscribeAsync(ctx *resolve.Context, id uint } func (f *FailingSubscriptionClient) Unsubscribe(id uint64) { - } func (f *FailingSubscriptionClient) Subscribe(ctx *resolve.Context, options GraphQLSubscriptionOptions, updater resolve.SubscriptionUpdater) error { @@ -8331,13 +8330,16 @@ func (t *testSubscriptionUpdater) Close(kind resolve.SubscriptionCloseKind) { t.closed = true } +// empty method to satisfy the interface, not used in this tests func (t *testSubscriptionUpdater) CloseSubscription(kind resolve.SubscriptionCloseKind, id resolve.SubscriptionIdentifier) { } +// empty method to satisfy the interface, not used in this tests func (t *testSubscriptionUpdater) Subscriptions() map[context.Context]resolve.SubscriptionIdentifier { return make(map[context.Context]resolve.SubscriptionIdentifier) } +// empty method to satisfy the interface, not used in this tests func (t *testSubscriptionUpdater) UpdateSubscription(id resolve.SubscriptionIdentifier, data []byte) { }