From 2d6f7a440799c8e84ee2c1975bfa97d4e018578c Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 15:53:25 +0200 Subject: [PATCH 01/15] refactor(ci): enhance query-planner CI workflow to check for engine changes - Renamed job from 'check-label' to 'check-label-and-engine-changes'. - Added a step to check for changes in the engine version. - Updated dependencies in subsequent jobs to reflect the new job name and outputs. --- .github/workflows/query-planner-ci.yaml | 31 ++++++++++++++++++------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index a9831da435..3f0d6d1ad0 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -21,10 +21,11 @@ concurrency: group: ${{github.workflow}}-${{github.head_ref}} cancel-in-progress: true jobs: - check-label: + check-label-and-engine-changes: runs-on: ubuntu-latest outputs: has_label: ${{ steps.check_label.outputs.has_label }} + engine_changed: ${{ steps.check_engine_changes.outputs.engine_changed }} steps: - name: Check for query-planner label id: check_label @@ -38,6 +39,18 @@ jobs: }); const hasLabel = labels.data.some(label => label.name === 'query-planner'); core.setOutput('has_label', hasLabel ? 'true' : 'false'); + - name: Check for changes of engine + id: check_engine_changes + run: | + current_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) + git checkout HEAD^ -- go.mod + previous_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) + if [ "$current_engine_version" != "$previous_engine_version" ]; then + echo "engine_changed=true" >> $GITHUB_OUTPUT + else + echo "engine_changed=false" >> $GITHUB_OUTPUT + fi + filter-changes: runs-on: ubuntu-latest outputs: @@ -113,13 +126,13 @@ jobs: build_test: # This job is use to lock the merge of the PR if anything fails in the query planner runs-on: ubuntu-latest if: ${{ always() }} - needs: [ build-router, build-cli, cli-release-url, check-label ] + needs: [ build-router, build-cli, cli-release-url, check-label-and-engine-changes ] outputs: workflow_url: ${{ steps.trigger_workflow.outputs.workflow_url }} workflow_id: ${{ steps.trigger_workflow.outputs.workflow_id }} steps: - uses: convictional/trigger-workflow-and-wait@v1.6.5 - if: ${{ needs.check-label.outputs.has_label == 'true' }} + if: ${{ needs.check-label-and-engine-changes.outputs.has_label == 'true' || needs.check-label-and-engine-changes.outputs.engine_changed == 'true' }} id: trigger_workflow name: Trigger Query Planner CI with: @@ -136,9 +149,9 @@ jobs: "wgc": "${{ needs.build-cli.outputs.wgc || needs.cli-release-url.outputs.wgc }}" } get_pr_url: - needs: [ build_test, check-label ] + needs: [ build_test, check-label-and-engine-changes ] runs-on: ubuntu-latest - if: ${{ always() && needs.check-label.outputs.has_label == 'true' }} + if: ${{ always() && (needs.check-label-and-engine-changes.outputs.has_label == 'true' || needs.check-label-and-engine-changes.outputs.engine_changed == 'true') }} outputs: pullrequest_url: ${{ steps.get_url.outputs.pr_url }} steps: @@ -174,8 +187,8 @@ jobs: pr_url=$(cat pr-url.txt) echo "pr_url=$pr_url" >> $GITHUB_OUTPUT comment-on-failure: - needs: [build_test, get_pr_url, check-label] - if: ${{ needs.check-label.outputs.has_label == 'true' && failure() }} + needs: [build_test, get_pr_url, check-label-and-engine-changes] + if: ${{ (needs.check-label-and-engine-changes.outputs.has_label == 'true' || needs.check-label-and-engine-changes.outputs.engine_changed == 'true') && failure() }} runs-on: ubuntu-latest steps: - name: Comment PR on failure @@ -193,8 +206,8 @@ jobs: The Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR. If you are part of the WunderGraph organization, you can [see the PR with more details](${{ needs.get_pr_url.outputs.pullrequest_url }}). comment-on-success: - needs: [build_test, get_pr_url, check-label] - if: ${{ needs.check-label.outputs.has_label == 'true' && success() }} + needs: [build_test, get_pr_url, check-label-and-engine-changes] + if: ${{ (needs.check-label-and-engine-changes.outputs.has_label == 'true' || needs.check-label-and-engine-changes.outputs.engine_changed == 'true') && success() }} runs-on: ubuntu-latest steps: - name: Comment PR on failure From 9f21e8644aa31cdff3acb21a5229ea14519cb611 Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 16:02:38 +0200 Subject: [PATCH 02/15] chore(ci): include query-planner CI workflow in file change checks --- .github/workflows/query-planner-ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 3f0d6d1ad0..4720f12f86 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -10,6 +10,7 @@ on: - 'router/**/*' - 'connect/**/*' - '.github/workflows/router-ci.yaml' + - '.github/workflows/query-planner-ci.yaml' env: CI: true DO_NOT_TRACK: '1' From 94bbf3875774244f07d56812e62b628326423044 Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 16:16:06 +0200 Subject: [PATCH 03/15] chore(ci): add checkout step to query-planner CI workflow --- .github/workflows/query-planner-ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 4720f12f86..672312e48b 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -28,6 +28,8 @@ jobs: has_label: ${{ steps.check_label.outputs.has_label }} engine_changed: ${{ steps.check_engine_changes.outputs.engine_changed }} steps: + - name: Checkout Code + uses: actions/checkout@v4 - name: Check for query-planner label id: check_label uses: actions/github-script@v6 From 88304fc142ce40ab2524c077af9cbf5714502c65 Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 16:17:19 +0200 Subject: [PATCH 04/15] chore(ci): set working directory for engine changes check in query-planner CI workflow --- .github/workflows/query-planner-ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 672312e48b..91aae539c1 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -44,6 +44,7 @@ jobs: core.setOutput('has_label', hasLabel ? 'true' : 'false'); - name: Check for changes of engine id: check_engine_changes + working-directory: cosmo run: | current_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) git checkout HEAD^ -- go.mod From 6214ac8e9bb444a99d37303faa9144dd7be61d2d Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 16:21:48 +0200 Subject: [PATCH 05/15] chore(ci): update working directory for engine changes check in query-planner CI workflow --- .github/workflows/query-planner-ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 91aae539c1..784a5d1751 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -44,7 +44,7 @@ jobs: core.setOutput('has_label', hasLabel ? 'true' : 'false'); - name: Check for changes of engine id: check_engine_changes - working-directory: cosmo + working-directory: router run: | current_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) git checkout HEAD^ -- go.mod From e8c044aeb9faf0793d8e6a95b68b92bd77a9e0ef Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 16:45:19 +0200 Subject: [PATCH 06/15] chore(ci): update fetch depth in checkout step of query-planner CI workflow --- .github/workflows/query-planner-ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 784a5d1751..4a1dcd33cb 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -30,6 +30,8 @@ jobs: steps: - name: Checkout Code uses: actions/checkout@v4 + with: + fetch-depth: 2 - name: Check for query-planner label id: check_label uses: actions/github-script@v6 From 6ecb939e798a60084f91367b11110037da2ca096 Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 17:05:52 +0200 Subject: [PATCH 07/15] chore(deps): downgrade graphql-go-tools to v2.0.0-rc.213.0 to maintain compatibility to test it --- router/go.mod | 2 +- router/go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/router/go.mod b/router/go.mod index 402ab2d326..a16376627b 100644 --- a/router/go.mod +++ b/router/go.mod @@ -31,7 +31,7 @@ require ( github.com/tidwall/gjson v1.18.0 github.com/tidwall/sjson v1.2.5 github.com/twmb/franz-go v1.16.1 - github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220 + github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.213.0.20250825082842-0efce3cfd008 // Do not upgrade, it renames attributes we rely on go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0 go.opentelemetry.io/contrib/propagators/b3 v1.23.0 diff --git a/router/go.sum b/router/go.sum index 0f23a8fce4..c612014c72 100644 --- a/router/go.sum +++ b/router/go.sum @@ -317,8 +317,8 @@ github.com/wk8/go-ordered-map/v2 v2.1.8 h1:5h/BUHu93oj4gIdvHHHGsScSTMijfx5PeYkE/ github.com/wk8/go-ordered-map/v2 v2.1.8/go.mod h1:5nJHM5DyteebpVlHnWMV0rPz6Zp7+xBAnxjb1X5vnTw= github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083 h1:8/D7f8gKxTBjW+SZK4mhxTTBVpxcqeBgWF1Rfmltbfk= github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083/go.mod h1:eOTL6acwctsN4F3b7YE+eE2t8zcJ/doLm9sZzsxxxrE= -github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220 h1:+imPYcv+XExZ+ofX5jCxtaA7upeys7uWA7RsTZiTTWE= -github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI= +github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.213.0.20250825082842-0efce3cfd008 h1:v/YrpaN3MdJmS/E9jH4P62oL12shYPqgjoG0/RkLbXU= +github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.213.0.20250825082842-0efce3cfd008/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI= github.com/yosida95/uritemplate/v3 v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4= github.com/yosida95/uritemplate/v3 v3.0.2/go.mod h1:ILOh0sOhIJR3+L/8afwt/kE++YT040gmv5BQTMR2HP4= github.com/yuin/gopher-lua v1.1.1 h1:kYKnWBjvbNP4XLT3+bPEwAXJx262OhaHDWDVOPjL46M= From b43567c66655d841aa89f48980588b805c4cceed Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 17:12:48 +0200 Subject: [PATCH 08/15] chore(deps): update graphql-go-tools to v2.0.0-rc.220 for improved compatibility --- router/go.mod | 2 +- router/go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/router/go.mod b/router/go.mod index a16376627b..402ab2d326 100644 --- a/router/go.mod +++ b/router/go.mod @@ -31,7 +31,7 @@ require ( github.com/tidwall/gjson v1.18.0 github.com/tidwall/sjson v1.2.5 github.com/twmb/franz-go v1.16.1 - github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.213.0.20250825082842-0efce3cfd008 + github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220 // Do not upgrade, it renames attributes we rely on go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0 go.opentelemetry.io/contrib/propagators/b3 v1.23.0 diff --git a/router/go.sum b/router/go.sum index c612014c72..0f23a8fce4 100644 --- a/router/go.sum +++ b/router/go.sum @@ -317,8 +317,8 @@ github.com/wk8/go-ordered-map/v2 v2.1.8 h1:5h/BUHu93oj4gIdvHHHGsScSTMijfx5PeYkE/ github.com/wk8/go-ordered-map/v2 v2.1.8/go.mod h1:5nJHM5DyteebpVlHnWMV0rPz6Zp7+xBAnxjb1X5vnTw= github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083 h1:8/D7f8gKxTBjW+SZK4mhxTTBVpxcqeBgWF1Rfmltbfk= github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083/go.mod h1:eOTL6acwctsN4F3b7YE+eE2t8zcJ/doLm9sZzsxxxrE= -github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.213.0.20250825082842-0efce3cfd008 h1:v/YrpaN3MdJmS/E9jH4P62oL12shYPqgjoG0/RkLbXU= -github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.213.0.20250825082842-0efce3cfd008/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI= +github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220 h1:+imPYcv+XExZ+ofX5jCxtaA7upeys7uWA7RsTZiTTWE= +github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI= github.com/yosida95/uritemplate/v3 v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4= github.com/yosida95/uritemplate/v3 v3.0.2/go.mod h1:ILOh0sOhIJR3+L/8afwt/kE++YT040gmv5BQTMR2HP4= github.com/yuin/gopher-lua v1.1.1 h1:kYKnWBjvbNP4XLT3+bPEwAXJx262OhaHDWDVOPjL46M= From 663953240ace557e842f2acb82c3a59043b4a3fb Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 17:22:54 +0200 Subject: [PATCH 09/15] fix(ci): update checkout command in query-planner CI workflow to use pull request base SHA for go.mod --- .github/workflows/query-planner-ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 4a1dcd33cb..e6a0a34586 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -49,7 +49,7 @@ jobs: working-directory: router run: | current_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) - git checkout HEAD^ -- go.mod + git checkout ${{ github.event.pull_request.base.sha }} -- go.mod previous_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) if [ "$current_engine_version" != "$previous_engine_version" ]; then echo "engine_changed=true" >> $GITHUB_OUTPUT From 436a7e23e66046a2453319a31495a6915d6e8ef6 Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 17:56:29 +0200 Subject: [PATCH 10/15] chore(ci): enhance query-planner CI workflow by setting fetch depth to 0 and adding Go setup step --- .github/workflows/query-planner-ci.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index e6a0a34586..1f1ab91da3 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -31,7 +31,12 @@ jobs: - name: Checkout Code uses: actions/checkout@v4 with: - fetch-depth: 2 + fetch-depth: 0 + - name: Setup Go + uses: actions/setup-go@v5 + with: + go-version-file: router/go.mod + cache: true - name: Check for query-planner label id: check_label uses: actions/github-script@v6 @@ -48,9 +53,9 @@ jobs: id: check_engine_changes working-directory: router run: | - current_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) - git checkout ${{ github.event.pull_request.base.sha }} -- go.mod - previous_engine_version=$(go list -json -m github.com/wundergraph/graphql-go-tools/v2 | jq .Sum) + current_engine_version=$(go list -f '{{.Sum}}' -m github.com/wundergraph/graphql-go-tools/v2) + git -C "$GITHUB_WORKSPACE" show ${{ github.event.pull_request.base.sha }}:router/go.mod > /tmp/base.go.mod + previous_engine_version=$(go list -f '{{.Sum}}' -modfile /tmp/base.go.mod -m github.com/wundergraph/graphql-go-tools/v2) if [ "$current_engine_version" != "$previous_engine_version" ]; then echo "engine_changed=true" >> $GITHUB_OUTPUT else From fdea26d26fddac3e85f486dcde91177d3539a1fb Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 18:14:57 +0200 Subject: [PATCH 11/15] fix: default router version --- .github/workflows/query-planner-ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 1f1ab91da3..c7e5c5306e 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -156,7 +156,7 @@ jobs: client_payload: >- { "branch": "query-plan/pr-${{ github.event.pull_request.number }}", - "router": "${{ needs.build-router.outputs.image_ref || 'ghcr.io/wundergraph/router:latest' }}", + "router": "${{ needs.build-router.outputs.image_ref || 'ghcr.io/wundergraph/cosmo/router:latest' }}", "wgc": "${{ needs.build-cli.outputs.wgc || needs.cli-release-url.outputs.wgc }}" } get_pr_url: From 6506ae88829115409bf513baa50f25a8d12cbb2c Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 18:23:50 +0200 Subject: [PATCH 12/15] chore(ci): add logging for engine version changes in query-planner CI workflow --- .github/workflows/query-planner-ci.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index c7e5c5306e..09e4bd0ea3 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -58,8 +58,10 @@ jobs: previous_engine_version=$(go list -f '{{.Sum}}' -modfile /tmp/base.go.mod -m github.com/wundergraph/graphql-go-tools/v2) if [ "$current_engine_version" != "$previous_engine_version" ]; then echo "engine_changed=true" >> $GITHUB_OUTPUT + echo "Engine has been changed from $previous_engine_version to $current_engine_version" else echo "engine_changed=false" >> $GITHUB_OUTPUT + echo "Engine has not been changed" fi filter-changes: From 55e814d91307d2ecedacffd984208fd1a97eaa37 Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 18:25:54 +0200 Subject: [PATCH 13/15] fix(ci): correct command to retrieve base go.mod file in query-planner CI workflow --- .github/workflows/query-planner-ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 09e4bd0ea3..d2bde80e84 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -54,7 +54,7 @@ jobs: working-directory: router run: | current_engine_version=$(go list -f '{{.Sum}}' -m github.com/wundergraph/graphql-go-tools/v2) - git -C "$GITHUB_WORKSPACE" show ${{ github.event.pull_request.base.sha }}:router/go.mod > /tmp/base.go.mod + git show ${{ github.event.pull_request.base.sha }}:router/go.mod > /tmp/base.go.mod previous_engine_version=$(go list -f '{{.Sum}}' -modfile /tmp/base.go.mod -m github.com/wundergraph/graphql-go-tools/v2) if [ "$current_engine_version" != "$previous_engine_version" ]; then echo "engine_changed=true" >> $GITHUB_OUTPUT From 0d3aff87b27e786e61805c8647ff870f8749c01e Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 18:35:29 +0200 Subject: [PATCH 14/15] fix(ci): update base go.mod file retrieval method in query-planner CI workflow --- .github/workflows/query-planner-ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index d2bde80e84..6d084ea0f7 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -54,8 +54,8 @@ jobs: working-directory: router run: | current_engine_version=$(go list -f '{{.Sum}}' -m github.com/wundergraph/graphql-go-tools/v2) - git show ${{ github.event.pull_request.base.sha }}:router/go.mod > /tmp/base.go.mod - previous_engine_version=$(go list -f '{{.Sum}}' -modfile /tmp/base.go.mod -m github.com/wundergraph/graphql-go-tools/v2) + git show ${{ github.event.pull_request.base.sha }}:router/go.mod > base.go.mod + previous_engine_version=$(go list -f '{{.Sum}}' -modfile base.go.mod -m github.com/wundergraph/graphql-go-tools/v2) if [ "$current_engine_version" != "$previous_engine_version" ]; then echo "engine_changed=true" >> $GITHUB_OUTPUT echo "Engine has been changed from $previous_engine_version to $current_engine_version" From 16936c58168489b36d00880212978cdc595abb68 Mon Sep 17 00:00:00 2001 From: Alessandro Pagnin Date: Mon, 25 Aug 2025 18:47:36 +0200 Subject: [PATCH 15/15] chore: use version --- .github/workflows/query-planner-ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/query-planner-ci.yaml b/.github/workflows/query-planner-ci.yaml index 6d084ea0f7..77324ed846 100644 --- a/.github/workflows/query-planner-ci.yaml +++ b/.github/workflows/query-planner-ci.yaml @@ -53,9 +53,9 @@ jobs: id: check_engine_changes working-directory: router run: | - current_engine_version=$(go list -f '{{.Sum}}' -m github.com/wundergraph/graphql-go-tools/v2) + current_engine_version=$(go list -f '{{.Version}}' -m github.com/wundergraph/graphql-go-tools/v2) git show ${{ github.event.pull_request.base.sha }}:router/go.mod > base.go.mod - previous_engine_version=$(go list -f '{{.Sum}}' -modfile base.go.mod -m github.com/wundergraph/graphql-go-tools/v2) + previous_engine_version=$(go list -f '{{.Version}}' -modfile base.go.mod -m github.com/wundergraph/graphql-go-tools/v2) if [ "$current_engine_version" != "$previous_engine_version" ]; then echo "engine_changed=true" >> $GITHUB_OUTPUT echo "Engine has been changed from $previous_engine_version to $current_engine_version"