Skip to content

Commit 91f50b3

Browse files
authored
fix: remove double frontend requests to controlplane (#1458)
1 parent 9d3ca55 commit 91f50b3

File tree

2 files changed

+17
-28
lines changed

2 files changed

+17
-28
lines changed

studio/src/pages/[organizationSlug]/[namespace]/graph/[slug]/analytics/index.tsx

+10-26
Original file line numberDiff line numberDiff line change
@@ -41,44 +41,28 @@ import {
4141
} from "@wundergraph/cosmo-connect/dist/platform/v1/platform-PlatformService_connectquery";
4242
import { formatISO } from "date-fns";
4343
import { useContext } from "react";
44+
import { AnalyticsViewResultFilter } from "@wundergraph/cosmo-connect/dist/platform/v1/platform_pb";
4445

4546
export type OperationAnalytics = {
4647
name: string;
4748
content: string;
4849
operationType: number;
4950
};
5051

51-
const OverviewToolbar = () => {
52+
const OverviewToolbar = ({
53+
filters,
54+
}: {
55+
filters?: AnalyticsViewResultFilter[];
56+
}) => {
5257
const graphContext = useContext(GraphContext);
5358
const client = useQueryClient();
5459

55-
const { filters, range, dateRange, refreshInterval } =
56-
useAnalyticsQueryState();
60+
const { range, dateRange, refreshInterval } = useAnalyticsQueryState();
5761

5862
const isFetching = useIsFetching();
5963

60-
const { data } = useQuery(
61-
getGraphMetrics,
62-
{
63-
namespace: graphContext?.graph?.namespace,
64-
federatedGraphName: graphContext?.graph?.name,
65-
dateRange: range
66-
? undefined
67-
: {
68-
start: formatISO(dateRange.start),
69-
end: formatISO(dateRange.end),
70-
},
71-
range,
72-
filters,
73-
},
74-
{
75-
placeholderData: keepPreviousData,
76-
refetchOnWindowFocus: false,
77-
},
78-
);
79-
8064
const { filtersList, selectedFilters, resetFilters } = useMetricsFilters(
81-
data?.filters ?? [],
65+
filters ?? [],
8266
);
8367

8468
const applyParams = useApplyParams();
@@ -124,7 +108,7 @@ const OverviewToolbar = () => {
124108
calendarDaysLimit={analyticsRetention}
125109
/>
126110

127-
<MetricsFilters filters={data?.filters ?? []} />
111+
<MetricsFilters filters={filters ?? []} />
128112
<AnalyticsSelectedFilters
129113
filters={filtersList}
130114
selectedFilters={selectedFilters}
@@ -211,7 +195,7 @@ const AnalyticsPage: NextPageWithLayout = () => {
211195

212196
return (
213197
<div className="w-full space-y-4">
214-
<OverviewToolbar />
198+
<OverviewToolbar filters={data?.filters} />
215199
<div className="flex flex-col gap-4 lg:grid lg:grid-cols-3">
216200
<RequestMetricsCard data={data?.requests} />
217201
<LatencyMetricsCard data={data?.latency} />

studio/src/pages/[organizationSlug]/apikeys.tsx

+7-2
Original file line numberDiff line numberDiff line change
@@ -699,11 +699,13 @@ export const Empty = ({
699699
setApiKey,
700700
open,
701701
setOpen,
702+
refetch,
702703
}: {
703704
apiKey: string | undefined;
704705
setApiKey: Dispatch<SetStateAction<string | undefined>>;
705706
open: boolean;
706707
setOpen: Dispatch<SetStateAction<boolean>>;
708+
refetch: () => void;
707709
}) => {
708710
const user = useContext(UserContext);
709711

@@ -735,6 +737,7 @@ export const Empty = ({
735737
setApiKey={setApiKey}
736738
open={open}
737739
setOpen={setOpen}
740+
refetch={refetch}
738741
/>
739742
)}
740743
</div>
@@ -748,14 +751,14 @@ export const CreateAPIKey = ({
748751
setApiKey,
749752
open,
750753
setOpen,
754+
refetch,
751755
}: {
752756
apiKey: string | undefined;
753757
setApiKey: Dispatch<SetStateAction<string | undefined>>;
754758
open: boolean;
755759
setOpen: Dispatch<SetStateAction<boolean>>;
760+
refetch: () => void;
756761
}) => {
757-
const { refetch } = useQuery(getAPIKeys);
758-
759762
useEffect(() => {
760763
if (!apiKey) return;
761764
setOpen(true);
@@ -810,6 +813,7 @@ const APIKeysPage: NextPageWithLayout = () => {
810813
setApiKey={setApiKey}
811814
open={openApiKeyCreatedDialog}
812815
setOpen={setOpenApiKeyCreatedDialog}
816+
refetch={refetch}
813817
/>
814818
) : (
815819
<>
@@ -850,6 +854,7 @@ const APIKeysPage: NextPageWithLayout = () => {
850854
setApiKey={setApiKey}
851855
open={openApiKeyCreatedDialog}
852856
setOpen={setOpenApiKeyCreatedDialog}
857+
refetch={refetch}
853858
/>
854859
)}
855860
</div>

0 commit comments

Comments
 (0)