Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

points_to_evaluate.shape #44

Open
shalijiang opened this issue Apr 23, 2018 · 2 comments
Open

points_to_evaluate.shape #44

shalijiang opened this issue Apr 23, 2018 · 2 comments

Comments

@shalijiang
Copy link

moe/optimal_learning/python/cpp_wrappers/expected_improvement_mcmc.py
class ExpectedImprovementMCMC
def evaluate_at_point_list()
line 219 says:
:type points_to_evaluate: array of float64 with shape (num_to_evaluate, self.dim)
so the shape here should be a tuple of 2.

but in line 246:
num_to_evaluate, num_to_sample, _ = points_to_evaluate.shape
it's expected tuple of 3.

Is there something wrong?

@wujian16
Copy link
Owner

(1) All the comments are outdated. We will put significant efforts to revise all the comments this summer, you can expect an update then.
(2) evaluate_at_point_list() is not tested, and subject to errors, instead please use compute_objective_function() within a loop over the point list.

@shalijiang
Copy link
Author

thanks, that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants