Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests - wrong version of Python? #3

Closed
colin-nolan opened this issue Sep 8, 2017 · 4 comments
Closed

Failing tests - wrong version of Python? #3

colin-nolan opened this issue Sep 8, 2017 · 4 comments

Comments

@colin-nolan
Copy link
Contributor

I had a go at running the test but unfortunately a couple fail, complaining:

TypeError: a bytes-like object is required, not 'str'

This screams of a Python 2 vs Python 3 issue. What version of Python is this tool designed for (it's not documented)? I assumed it would work on 3.6 but perhaps I'm wrong here!

@ThomasHickman
Copy link
Contributor

Apart from running this tool with the option --dev (which uses requests_cache, which fails in python 3), this should work in both python 2 and 3. What's the full error message?

@ThomasHickman
Copy link
Contributor

... also the tests don't work unless you have the cwl-example-data folder, which shouldn't be committed to git

@colin-nolan
Copy link
Contributor Author

Yea, I was a bit confused about what data I needed there. Can I just add any set of valid chr22_cwl_test.* files? Do you know if there's any publically accessible files that could be used here?

@ThomasHickman ThomasHickman self-assigned this Sep 8, 2017
@ThomasHickman
Copy link
Contributor

Looks like it is a python 3 problem, as the tests work on python 2 but not python 3. Looking into fixing it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants